Bug 2262770 - Review Request: ghc-s-cargot - A flexible, extensible s-expression library
Summary: Review Request: ghc-s-cargot - A flexible, extensible s-expression library
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jens Petersen
QA Contact: Fedora Extras Quality Assurance
URL: https://hackage.haskell.org/package/s...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-05 11:47 UTC by Frank Dedden
Modified: 2024-07-02 15:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-07-02 15:21:51 UTC
Type: ---
Embargoed:
petersen: fedora-review+


Attachments (Terms of Use)

Description Frank Dedden 2024-02-05 11:47:29 UTC
Spec URL: https://fdedden.fedorapeople.org/ghc-s-cargot.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-s-cargot-0.1.6.0-1.fc40.src.rpm

Description:
S-Cargot is a library for working with s-expressions in a modular and
extensible way, opting for genericity and flexibility instead of speed.
Instead of understanding one particular form of s-expression, the S-Cargot
library exposes tools for parsing or emitting different kinds of s-expressions,
including features not normally included in an s-expression library like reader
macros or tight control over indentation in pretty-printing.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-02-05 11:47:33 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112968741

Comment 2 Fedora Review Service 2024-02-05 11:59:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6986355
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262770-ghc-s-cargot/fedora-rawhide-x86_64/06986355-ghc-s-cargot/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jens Petersen 2024-05-28 15:07:07 UTC
The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and LGTM.
License is BSD3.

You could try enabling the testsuite.

Package APPROVED

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-01 13:21:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-s-cargot

Comment 5 Frank Dedden 2024-07-02 15:21:51 UTC
I have enabled the test-suite, and the package built successfully. It has been added to rawhide.


Note You need to log in before you can comment on or make changes to this bug.