Fedora Merge Review: perl-String-CRC32
Initial Owner: email@example.com
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
All tests successful.
Files=1, Tests=27, 0 wallclock secs ( 0.01 cusr + 0.00 csys = 0.01 CPU)
+ Package perl-String-CRC32-1.4-3.fc8 ->
Provides: CRC32.so perl(String::CRC32) = 1.4
Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4)
perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(Exporter) rtld(GNU_HASH)
Can we CLOSE this review if package is already built and in rawhide?