Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-diff6.git/plain/php-sebastian-diff6.spec?id=d0926c0503ee8a513e6ffabf39b468f06d424eea SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-diff6-6.0.0-1.remi.src.rpm Description: Diff implementation. This package provides version 6 of sebastian/diff library. Autoloader: /usr/share/php/SebastianBergmann/Diff6/autoload.php Fedora Account System Username: remi -- Previous version review bug #2167794
Copr build: https://copr.fedorainfracloud.org/coprs/build/6986684 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262807-php-sebastian-diff6/fedora-rawhide-x86_64/06986684-php-sebastian-diff6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Update to 6.0.1 Spec URL: https://git.remirepo.net/cgit/rpms/php/phpunit/php-sebastian-diff6.git/plain/php-sebastian-diff6.spec?id=0babe99d34bd92027b4f589c64d2c53f85b7f354 SRPM URL: https://rpms.remirepo.net/SRPMS/php-sebastian-diff6-6.0.1-1.remi.src.rpm
Created attachment 2020176 [details] The .spec file difference from Copr build 6986684 to 7106982
Copr build: https://copr.fedorainfracloud.org/coprs/build/7106982 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262807-php-sebastian-diff6/fedora-rawhide-x86_64/07106982-php-sebastian-diff6/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- In %files, please drop : # remirepo:1 %{!?_licensedir:%global license %%doc} - Add a comment about upstream tarball missing tests. - In %check, please drop # remirepo:5 - In %check, does it really make sense to support EL7 at this time ? Also, conditional could be written %{?el7} - I must admit I'm not overly fond of the bundled symfony-process, but so be it... Full review incoming...
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* BSD 3-Clause License", "MIT License", "*No copyright* MIT License". 76 files have unknown license. Detailed output of licensecheck in /home/xavierb/fedora.git/perl-Carp-Assert-More/2262807-php-sebastian- diff6/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/php [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 17156 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: usage /usr/share/php-bartlett-PHP-CompatInfo/fedora-review-check logname dirname 7.1.2@072d0f8 static analyze results in /home/xavierb/fedora.git/perl-Carp-Assert-More/2262807-php-sebastian- diff6/phpci.log Rpmlint ------- Checking: php-sebastian-diff6-6.0.1-1.fc41.noarch.rpm php-sebastian-diff6-6.0.1-1.fc41.src.rpm ======================================================================================================== rpmlint session starts ======================================================================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwir8qmdk')] checks: 32, packages: 2 php-sebastian-diff6.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader') php-sebastian-diff6.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') php-sebastian-diff6.src: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader') php-sebastian-diff6.src: E: spelling-error ('usr', '%description -l en_US usr -> use, us, user') php-sebastian-diff6.src: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') php-sebastian-diff6.spec: W: invalid-url Source0: php-sebastian-diff6-6.0.1-ab83243.tgz =================================================================== 2 packages and 0 specfiles checked; 5 errors, 1 warnings, 7 filtered, 5 badness; has taken 0.3 s ================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 php-sebastian-diff6.noarch: E: spelling-error ('Autoloader', '%description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader') php-sebastian-diff6.noarch: E: spelling-error ('autoload', '%description -l en_US autoload -> auto load, auto-load, tautology') 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 3 filtered, 2 badness; has taken 0.1 s Source checksums ---------------- https://github.com/symfony/process/archive/v5.4.35/php-symfony-process-5.4.35.tar.gz : CHECKSUM(SHA256) this package : ae5dfa7459495850ee5d6b3ff4b19b1edaed57d371d2dedd419ac1d5041ebc71 CHECKSUM(SHA256) upstream package : ae5dfa7459495850ee5d6b3ff4b19b1edaed57d371d2dedd419ac1d5041ebc71 Requires -------- php-sebastian-diff6 (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-pcre php-spl Provides -------- php-sebastian-diff6: php-composer(sebastian/diff) php-sebastian-diff6 Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2262807 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, PHP Disabled plugins: fonts, Java, Haskell, Perl, Python, R, SugarActivity, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-sebastian-diff6
Thanks for the review https://pagure.io/releng/fedora-scm-requests/issue/60866 https://pagure.io/releng/fedora-scm-requests/issue/60867 https://pagure.io/releng/fedora-scm-requests/issue/60868
FEDORA-2024-8db29570c3 (php-sebastian-diff6-6.0.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8db29570c3
FEDORA-2024-167a9ac21c has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-167a9ac21c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-167a9ac21c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-8db29570c3 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-8db29570c3 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8db29570c3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-8db29570c3 (php-sebastian-diff6-6.0.1-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-167a9ac21c (php-sebastian-diff6-6.0.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.