Fedora Merge Review: perl-TermReadKey http://cvs.fedora.redhat.com/viewcvs/devel/perl-TermReadKey/ Initial Owner: rnorwood
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)drop "|| :" from %check 3)rpmlint only complained -> perl-TermReadKey.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
all issues above fixed. Also added %{?dist} tag to release New version is 2.30-3.fc9
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url f0ef2cea8acfbcc58d865c05b0c7e1ff TermReadKey-2.30.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" -w test.pl 1 .. 8 ok 1 ok 2 # skip /dev/tty is absent ok 3 # skip /dev/tty is absent ok 4 # skip /dev/tty is absent ok 5 # skip /dev/tty is absent ok 6 # skip /dev/tty is absent ok 7 # skip /dev/tty is absent ok 8 # skip /dev/tty is absent + Package perl-TermReadKey-2.30-3.fc8 -> Provides: ReadKey.so perl(Term::ReadKey) = 2.30 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) perl(:MODULE_COMPAT_5.8.8) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) rtld(GNU_HASH) APPROVED.
Can we CLOSE this review if package is already built and in rawhide?
*** Bug 516249 has been marked as a duplicate of this bug. ***
Package Change Request ====================== Package Name: perl-TermReadKey InitialCC: perl-sig Please add into CC perl-sig.
Please don't include a change request if you're not going to include a proper one; it just confuses the scripts. Simply raising the flag and describing what you need done should be sufficient. I added perl-sig to all of the Fedora branches.
Current package declares license `Copyright only'. However sources contains ppport.h which is `Artistic or GPL+' and which results into distributed shared library. Thus the package should declare `Artistic or GPL+'. I will fix it.