Bug 226293 - Merge Review: pfmon
Merge Review: pfmon
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Thomas Spura
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 15:39 EST by Nobody's working on this, feel free to take it
Modified: 2010-07-19 06:41 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-07-19 06:41:53 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:39:44 EST
Fedora Merge Review: pfmon

Initial Owner: wcohen@redhat.com
Comment 1 William Cohen 2007-05-21 12:33:50 EDT
Someone else needs to do the review. However, there are a couple things that can
be fixed based on rpmlint:

$ rpmlint pfmon-3.2-0.061205.1.fc8.src.rpm 
W: pfmon summary-not-capitalized a performance monitoring tool for Linux/ia64
W: pfmon no-url-tag
W: pfmon hardcoded-path-in-buildroot-tag /var/tmp/pfmon-root
W: pfmon buildprereq-use elfutils-devel
W: pfmon buildprereq-use binutils-devel
W: pfmon buildprereq-use libpfm >= 3.2-0.061205
W: pfmon buildprereq-use libpfm-devel >= 3.2-0.061205
W: pfmon rpm-buildroot-usage %build make        PREFIX=/usr DESTDIR=%{buildroot} \

Have fixes for all of the above warnings with the exception of the
Comment 2 Patrice Dumas 2007-11-14 18:25:19 EST
Many comments of lipfm are valid here. 

Additionaly the Buildrequires should be

BuildRequires: libpfm-devel >= 3.2-0.071017

Regarding the 
W: pfmon rpm-buildroot-usage %build make        PREFIX=/usr DESTDIR=%{buildroot} \
it is because in %build DESTDIR=%{buildroot} shouldnt be useful nor used.
The other flags should also be checked, since some may only be
useful in %install.
Comment 3 Thomas Spura 2010-07-19 06:41:53 EDT
According to:

this is obsoleted by perf.


Note You need to log in before you can comment on or make changes to this bug.