Bug 2262965 - Review Request: python-hsluv - a Python implementation of HSLuv (revision 4)
Summary: Review Request: python-hsluv - a Python implementation of HSLuv (revision 4)
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://www.hsluv.org/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-06 10:26 UTC by José Matos
Modified: 2024-02-11 16:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 6988868 to 7007688 (864 bytes, patch)
2024-02-11 16:16 UTC, Fedora Review Service
no flags Details | Diff

Description José Matos 2024-02-06 10:26:39 UTC
Spec URL: https://jamatos.fedorapeople.org/python-hsluv.spec
SRPM URL: https://jamatos.fedorapeople.org/python-hsluv-5.0.4-1.fc39.src.rpm
Description: A Python implementation of HSLuv (revision 4).
Fedora Account System Username: jamatos

This package is the remaining unmet dependency in the upgrade of nikola (static site generator)

Comment 1 Fedora Review Service 2024-02-06 10:30:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6988868
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262965-python-hsluv/fedora-rawhide-x86_64/06988868-python-hsluv/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Maxwell G 2024-02-11 00:54:56 UTC
> Source0:	https://files.pythonhosted.org/packages/source/h/hsluv/hsluv-%{version}.tar.gz

You should use %{pypi_source hsluv} instead of manually specifying the URL.

> %pyproject_buildrequires -t

You can remove the -t flag. This project does not use tox.

Comment 3 José Matos 2024-02-11 09:46:40 UTC
(In reply to Maxwell G from comment #2)
> > Source0:	https://files.pythonhosted.org/packages/source/h/hsluv/hsluv-%{version}.tar.gz
> 
> You should use %{pypi_source hsluv} instead of manually specifying the URL.

Done.

> > %pyproject_buildrequires -t
> 
> You can remove the -t flag. This project does not use tox.

Done.

New version below:
Spec URL: https://jamatos.fedorapeople.org/python-hsluv.spec
SRPM URL: https://jamatos.fedorapeople.org/python-hsluv-5.0.4-2.fc39.src.rpm

Comment 4 Fedora Review Service 2024-02-11 16:16:18 UTC
Created attachment 2016369 [details]
The .spec file difference from Copr build 6988868 to 7007688

Comment 5 Fedora Review Service 2024-02-11 16:16:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7007688
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262965-python-hsluv/fedora-rawhide-x86_64/07007688-python-hsluv/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.