Fedora Merge Review: prctl http://cvs.fedora.redhat.com/viewcvs/devel/prctl/ Initial Owner: karsten
prctl-1.5-2 prepared for review
Why is there an explicit ExclusiveArch: ia64 ? I can't find any documentation that indicates this software is only for ia64. Also, do we have a branch for the ia64 architecture at Fedora?
ping?
The only parameters of prctl that do anything other than printing help are --unaligned= and --fpemu=. Both work only on ia64, on other archs you'll get this output: 'ERROR: Kernel on this platform may not implement this prctl feature.' I've added this as a comment before the ExclusiveArch: in the spec file and commited it to CVS. As IA64 is a secondary arch in Fedora, a build will need to be done by the secondary arch maintainers. See https://fedoraproject.org/wiki/Architectures/IA64 for more info about Fedora-IA64
Thanks for the explanation. So I can't to do a test to evaluate the software but I could do a generic package review since it is a simple one. There is one minor issue and a few suggestions. Let me know whenever you update the package so we can close the bug. * rpmlint says prctl.src:22: W: setup-not-quiet You need to use %setup -q ! no disttag. I think it could be better to have a disttag to avoid incompatibilities between the binaries produced by different versions of the compiler. What do you think? ! The patch is trivial. I don't think it is necessary to submit upstream. It would be nice though. ! You can make use of the %{name} macro a little more frequent
I've added changes for those in CVS: - added disttag - setup -q - frequent use of %{name} macro with the exception of the URL, because that's the string I use with cut&paste and firefox to check if there's a new version.
Great! Thanks. --------------------------------------------- This Merge Review (prctl) is APPROVED by oget ---------------------------------------------