Bug 226320 - Merge Review: psacct
Merge Review: psacct
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:43 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-23 08:19:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmaslano: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:43:35 EST
Fedora Merge Review: psacct

http://cvs.fedora.redhat.com/viewcvs/devel/psacct/
Initial Owner: varekova@redhat.com
Comment 1 Marcela Mašláňová 2007-03-12 11:25:09 EDT
SRC
W: psacct no-url-tag
W: psacct strange-permission psacct.init 0775
W: psacct prereq-use /sbin/chkconfig /sbin/install-info
ARCH
W: psacct no-url-tag
W: psacct conffile-without-noreplace-flag /var/account/pacct
E: psacct non-readable /var/account/pacct 0600
W: psacct dangerous-command-in-%post mv

Replace buildroot.
Prereq  should be with post, pre, ...
Replace macro %{makeinstall}, if you can.
Defattr has 4 parametres.

mkdir -p $RPM_BUILD_ROOT{/sbin,%{_bindir},%{_mandir},%{_sbindir}}
Isn't $RPM_BUILD_ROOT/sbin the same as $RPM_BUILD_ROOT/%{_sbindir} ?
Comment 2 Paul Howarth 2007-03-12 12:21:10 EDT
(In reply to comment #1)
> Isn't $RPM_BUILD_ROOT/sbin the same as $RPM_BUILD_ROOT/%{_sbindir} ?

No:

$ rpm --eval '%{_sbindir}'
/usr/sbin
Comment 3 Ivana Varekova 2007-04-05 09:47:34 EDT
(In reply to comment #1)
> SRC
> W: psacct no-url-tag
- there is no upstream

> W: psacct strange-permission psacct.init 0775
- this could not be changed

> W: psacct prereq-use /sbin/chkconfig /sbin/install-info
- fixed

> W: psacct conffile-without-noreplace-flag /var/account/pacct
> E: psacct non-readable /var/account/pacct 0600
- this is not a problem

> W: psacct dangerous-command-in-%post mv
- this is not a problem
 
> Replace buildroot.
- fixed

> Replace macro %{makeinstall}, if you can.
- fixed

> Defattr has 4 parametres.
- fixed
 
> mkdir -p $RPM_BUILD_ROOT{/sbin,%{_bindir},%{_mandir},%{_sbindir}}
> Isn't $RPM_BUILD_ROOT/sbin the same as $RPM_BUILD_ROOT/%{_sbindir} ?
- no %{_sbindir} should be /usr/sbin directory

The fixed version is psacct-6.3.2-44.fc7.

Note You need to log in before you can comment on or make changes to this bug.