Fedora Merge Review: pydict http://cvs.fedora.redhat.com/viewcvs/devel/pydict/ Initial Owner: majain
- Buildroot is obsolete. Use %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) instead. rpmlint output is clean. MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. NEEDSFIX - There is no mention of a license in the package! MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. NEEDSFIX - Source url is missing! MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK MUST: Optflags are used and time stamps preserved. NEEDSFIX - Time stamps are lost in install and in character set conversion. MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. ~OK - Vendor tag is incorrect. In fact there shouldn't be any, but this can't be changed due to compatibility reasons. MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
ping rbhalera
ping again?
cc pnemade ping again
Thanks, I thought previous owner already fixed this package. I got it in June 2009 but was not knowing that time about this review. Will work on this on Monday.
please wait till Friday as I am checking if this package can be retired from Fedora as stardict looks providing same functionality and pydict code is having old function calls which are deprecated now.
Officially Retired this Package now.