Spec URL: https://github.com/dangel101/qtmqtt/blob/main/SPECS/qtmqtt.spec SRPM URL: https://github.com/dangel101/qtmqtt/blob/main/SRPMS/qtmqtt-6.6.0-1.fc39.src.rpm Description: QtMqtt module Fedora Account System Username: delfassy This is my first package, and I need a sponsor Link to Koji job: https://koji.fedoraproject.org/koji/taskinfo?taskID=113151750
1)
(In reply to Jan Grulich from comment #1) > 1) Didn't mean to submit it :) 1) The package should have name consistent with other Qt modules so it should be qt6-qtmqtt and not only qtmqtt. 2) Rawhide is currently on Qt 6.6.1 so please update it to match the Qt version there. 3) The source should point to link where you can get the tarball, in this case it should be something like https://github.com/qt/qtmqtt/archive/%{version}/%{name}-%{version}.tar.gz 4) BuildRequires: qt6-qtdeclarative-devel → shouldn't be needed as I can see in the CMakeLists.txt that it is used only for tests 5) Maybe extend the description with more information, something from https://doc.qt.io/qt-6/qtmqtt-index.html for example. 6) Both -examples and -devel are missing "Requires: %{name}%{?_isa} = %{version}-%{release}" to depend on the main package.
Thank you for your comments, I fixed the spec file accordingly The updated spec file can be found here: https://github.com/dangel101/qtmqtt/blob/main/SPECS/qtmqtt.spec The SRPM can be found here: https://github.com/dangel101/qtmqtt/blob/main/SRPMS/qt6-qtmqtt-6.6.1-1.fc39.src.rpm Koji job is here: https://koji.fedoraproject.org/koji/taskinfo?taskID=113402853
Only minor issues: 1) SPEC file is still wrongly named (the file itself I mean) 2) Description lines are too long, you should wrap at 80 characters.
Done, SPEC: https://github.com/dangel101/qtmqtt/blob/main/SPECS/qt6-qtmqtt.spec SRPM: https://github.com/dangel101/qtmqtt/blob/main/SRPMS/qt6-qtmqtt-6.6.1-1.fc39.src.rpm Koji job: https://koji.fedoraproject.org/koji/taskinfo?taskID=113404419
Looks good to me now. Approved.
Hello @delfassy, since this is your first Fedora package, you need to get sponsored by a package sponsor before it can be accepted. A sponsor is an experienced package maintainer who will guide you through the processes that you will follow and the tools that you will use as a future maintainer. A sponsor will also be there to answer your questions related to packaging. You can find all active sponsors here: https://docs.pagure.org/fedora-sponsors/ I created a sponsorship request for you: https://pagure.io/packager-sponsors/issue/624 Please take a look and make sure the information is correct. Thank you, and best of luck on your packaging journey. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
I've now sponsored you as a packager. Good luck!
The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6-qtmqtt
Fedora 41: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e88a09cc87 Fedora 40: https://bodhi.fedoraproject.org/updates/FEDORA-2024-8095ddf4d9 Fedora 39: https://bodhi.fedoraproject.org/updates/FEDORA-2024-64849ab939