Fedora Merge Review: PyQt http://cvs.fedora.redhat.com/viewcvs/devel/PyQt/ Initial Owner: than
PyQt looks good, simple and clean, APPROVED. A few small SHOULD items to consider post-merge: * -BuildRequires: libGL-devel libGLU-devel qt-devel Req's these now. * +BuildRequires: qscintilla-devel to build/include qscintilla extention (provided now by Extras' PyQt-qscintilla)
Source0 URL no longer exists, should be fixed.
Good catch, use (something like) Source0: http://www.riverbankcomputing.com/Downloads/PyQt3/GPL/PyQt-x11-gpl-%{version}.tar.gz instead.
Than, are you going to implement items from comment #1 (post merge), so we can put PyQt-qscintilla to rest? If so either preserve the -qscintilla/-qscintilla-devel subpkgs, or add Obsoletes: %{name}-qscintilla > %{version}-%{release} Provides: %{name}-qscintilla = %{version}-%{release} and add to -devel Obsoletes: %{name}-qscintilla-devel > %{version}-%{release} Provides: %{name}-qscintilla-devel = %{version}-%{release}
it seems the CVS has problem i cannot connect to CVS server. I will add the change in CVS when CVS works again.
Than, can you incorporate the qscintilla bits soon?
ping (3+ mos later...)
all done, merged.
Package Change Request ====================== Package Name: PyQt New Branches: el6 Owners: jgu
Are the existing maintainers on board with the EL-6 branch?
no objection
Thanks Rex - this is to solve BZ #847506 - ScientificPython-qt (built for EL6) requires PyQt.
Jon - did you mean to cancel the CVS flag?
Git done (by process-git-requests). At that time I did, yes. :)