Bug 226345 - Merge Review: python-numeric
Merge Review: python-numeric
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
7
All Linux
low Severity low
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:46 EST by Nobody's working on this, feel free to take it
Modified: 2010-12-21 00:59 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-30 01:46:58 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)
modified SPEC (1.39 KB, patch)
2008-01-16 03:45 EST, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:46:39 EST
Fedora Merge Review: python-numeric

http://cvs.fedora.redhat.com/viewcvs/devel/python-numeric/
Initial Owner: mbarnes@redhat.com
Comment 1 Parag AN(पराग) 2008-01-16 03:45:52 EST
Created attachment 291832 [details]
modified SPEC

I see some issues in this package. So Attaching patch that will fix some
issues.
Comment 2 Parag AN(पराग) 2008-01-16 03:48:04 EST
I dunno whether we can allow .h files installing from python-numeric as review
guidelines suggests
- MUST: Header files must be in a -devel package.
Comment 3 Parag AN(पराग) 2008-01-18 09:09:46 EST
ping?
Comment 4 Matthew Barnes 2008-01-18 10:15:59 EST
Will address this soon.  Higher priority tasks at the moment.
Comment 5 Matthew Barnes 2008-01-18 22:22:52 EST
Thanks for the review.  Patch applied to python-numeric-24.2-7.fc9.
Comment 6 Parag AN(पराग) 2008-01-19 05:57:36 EST
rpmlint on new package give ==>
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/ranlib.h
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/_numpy.so 0775
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/lapack_lite.so 0775
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/f2c.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/f2c.h
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/arrayfns.so 0775
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/umath.so 0775
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/ufuncobject.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/arrayobject.h
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/ranlib.so 0775
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ranlib.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/arrayobject.h
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/multiarray.so 0775
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/RNG/RNG.so 0775
python-numeric.i386: E: non-standard-executable-perm
/usr/lib/python2.5/site-packages/Numeric/FFT/fftpack.so 0775
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ufuncobject.h

I think ok to have header files in non-devel as this is python package but good
to change those incorrect permissions.
Comment 7 Parag AN(पराग) 2008-01-19 08:00:14 EST
Look like something goes wrong with above output. Sorry Correct output of rpmlint is
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/ranlib.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/f2c.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/f2c.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/ufuncobject.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/include/python2.5/Numeric/arrayobject.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ranlib.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/arrayobject.h
python-numeric.i386: W: devel-file-in-non-devel-package
/usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ufuncobject.h

which is ok.

1)Change Source URL to
http://downloads.sourceforge.net/numpy/Numeric-%{version}.tar.gz
2) Can't see eggs files generated here. See
http://fedoraproject.org/wiki/Packaging/Python/Eggs
Comment 8 Matthew Barnes 2008-01-21 10:58:27 EST
Source tag fixed in python-numeric-24.2-8.fc9.

According to the packaging guidelines for Python Eggs, the python-setuptools
package in Fedora 9 should handle egg-info files automatically.  But I'm not
familiar with egg-info files so maybe I'm missing something.
Comment 9 Parag AN(पराग) 2008-01-22 01:02:31 EST
guidelines suggests for F9 and above you should BR: python-setuptools-devel.
I did koji build by replacing that BR and you can see now its building egg-info
files.
http://koji.fedoraproject.org/koji/getfile?taskID=364841&name=build.log

you better add following in SPEC
%if 0%{?fedora} >= 8
BuildRequires: python-setuptools-devel
%else
BuildRequires: python-setuptools
%endif
Comment 10 Matthew Barnes 2008-01-29 14:14:23 EST
Fixed as suggested in python-numeric-24.2-9.fc9.
Comment 11 Parag AN(पराग) 2008-01-30 01:46:58 EST
Thanks for updates.
Packaging looks Ok.
APPROVED.
Comment 12 Alex Lancaster 2010-12-12 14:27:01 EST
This is needed in EPEL for installing pypop:  https://admin.fedoraproject.org/community/?package=pypop#package_maintenance

Package Change Request
======================
Package Name: python-numeric
New Branches: el5 el6
Owners: alexlan
Comment 13 Jason Tibbitts 2010-12-13 13:35:18 EST
Can we get an ack from a Fedora maintainer?
Comment 14 Alex Lancaster 2010-12-20 12:46:22 EST
(In reply to comment #13)
> Can we get an ack from a Fedora maintainer?

Re-requesting SCM branch, see bug #664399 comment #1 for ack.

Package Change Request
======================
Package Name: python-numeric
New Branches: el5 el6
Owners: alexlan
Comment 15 Matthew Barnes 2010-12-20 13:31:29 EST
This is okay by me (maintainer), go ahead with it.
Comment 16 Kevin Fenzi 2010-12-21 00:59:08 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.