Fedora Merge Review: python-numeric http://cvs.fedora.redhat.com/viewcvs/devel/python-numeric/ Initial Owner: mbarnes
Created attachment 291832 [details] modified SPEC I see some issues in this package. So Attaching patch that will fix some issues.
I dunno whether we can allow .h files installing from python-numeric as review guidelines suggests - MUST: Header files must be in a -devel package.
ping?
Will address this soon. Higher priority tasks at the moment.
Thanks for the review. Patch applied to python-numeric-24.2-7.fc9.
rpmlint on new package give ==> python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/ranlib.h python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/_numpy.so 0775 python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/lapack_lite.so 0775 python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/f2c.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/f2c.h python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/arrayfns.so 0775 python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/umath.so 0775 python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/ufuncobject.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/arrayobject.h python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/ranlib.so 0775 python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ranlib.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/arrayobject.h python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/multiarray.so 0775 python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/RNG/RNG.so 0775 python-numeric.i386: E: non-standard-executable-perm /usr/lib/python2.5/site-packages/Numeric/FFT/fftpack.so 0775 python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ufuncobject.h I think ok to have header files in non-devel as this is python package but good to change those incorrect permissions.
Look like something goes wrong with above output. Sorry Correct output of rpmlint is python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/ranlib.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/f2c.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/f2c.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/ufuncobject.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/include/python2.5/Numeric/arrayobject.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ranlib.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/arrayobject.h python-numeric.i386: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/Numeric/Numeric_headers/Numeric/ufuncobject.h which is ok. 1)Change Source URL to http://downloads.sourceforge.net/numpy/Numeric-%{version}.tar.gz 2) Can't see eggs files generated here. See http://fedoraproject.org/wiki/Packaging/Python/Eggs
Source tag fixed in python-numeric-24.2-8.fc9. According to the packaging guidelines for Python Eggs, the python-setuptools package in Fedora 9 should handle egg-info files automatically. But I'm not familiar with egg-info files so maybe I'm missing something.
guidelines suggests for F9 and above you should BR: python-setuptools-devel. I did koji build by replacing that BR and you can see now its building egg-info files. http://koji.fedoraproject.org/koji/getfile?taskID=364841&name=build.log you better add following in SPEC %if 0%{?fedora} >= 8 BuildRequires: python-setuptools-devel %else BuildRequires: python-setuptools %endif
Fixed as suggested in python-numeric-24.2-9.fc9.
Thanks for updates. Packaging looks Ok. APPROVED.
This is needed in EPEL for installing pypop: https://admin.fedoraproject.org/community/?package=pypop#package_maintenance Package Change Request ====================== Package Name: python-numeric New Branches: el5 el6 Owners: alexlan
Can we get an ack from a Fedora maintainer?
(In reply to comment #13) > Can we get an ack from a Fedora maintainer? Re-requesting SCM branch, see bug #664399 comment #1 for ack. Package Change Request ====================== Package Name: python-numeric New Branches: el5 el6 Owners: alexlan
This is okay by me (maintainer), go ahead with it.
Git done (by process-git-requests).