Bug 226347 - Merge Review: python-urlgrabber
Merge Review: python-urlgrabber
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Bryan Kearney
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 15:46 EST by Nobody's working on this, feel free to take it
Modified: 2013-01-10 04:06 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-08-27 11:28:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jbowes: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:46:54 EST
Fedora Merge Review: python-urlgrabber

http://cvs.fedora.redhat.com/viewcvs/devel/python-urlgrabber/
Initial Owner: katzj@redhat.com
Comment 1 James Bowes 2007-08-25 17:36:15 EDT
I'll review this.
Comment 2 James Bowes 2007-08-25 18:07:36 EDT
Notes:

X package meets packaging guidelines:
  %install should being by removing the buildroot
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* source files match upstream 
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock.

X rpmlint has 3 warnings:
  W: python-urlgrabber invalid-license LGPL
  W: python-urlgrabber redundant-prefix-tag
  W: python-urlgrabber setup-not-quiet

* final provides and requires are sane:
  urlgrabber = 3.0.0-1.fc7
  python-urlgrabber = 3.0.0-1.fc7
  ======
  /usr/bin/python  
  python(abi) = 2.5

* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* scriptlets OK
* code, not content.
* upstream includes no docs.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.

The license must be updated and %install must be fixed as well. The other two
rpmlint warnings should be fixed as well. Source0 should also be a url. I'll
approve the package when these are fixed.

Three nice to haves:
 * use one of the three standard buildroot definitions
 * use the 4 arg form of defattr
 * use the single '%{python_sitelib}/urlgrabber' in files rather than  the two     
   %dir and /* lines
Comment 3 Jeremy Katz 2007-08-27 11:24:22 EDT
All fixed for -2.
Comment 4 James Bowes 2007-08-27 11:28:43 EDT
(In reply to comment #3)
> All fixed for -2.

Great. Approved.

Note You need to log in before you can comment on or make changes to this bug.