Hide Forgot
Fedora Merge Review: rarpd http://cvs.fedora.redhat.com/viewcvs/devel/rarpd/ Initial Owner: pknirsch@redhat.com
NO source files match upstream. - The source URL is not accessible. I think Debian's ftp can be used instead http://ftp.debian.org/debian/pool/main/r/rarpd/ YES package meets naming and versioning guidelines. YES specfile is properly named, is cleanly written and uses macros consistently. YES dist tag is present. YES build root is correct. YES license field matches the actual license. YES license is open source-compatible. NO License text included in package. YES latest version is being packaged. YES BuildRequires are proper. YES compiler flags are appropriate. YES %clean is present. YES package builds in mock (Rawhide/x86_64). YES debuginfo package looks complete. NO rpmlint is silent. rarpd.x86_64: W: no-url-tag rarpd.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/rarpd rarpd.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/rarpd - do not mark initscript with %config - use %{_initddir} instead of /etc/rc.d/init.d NO final provides and requires look sane. - Prereq should be replaced with Requires N/A %check is present and all tests pass. YES no shared libraries are added to the regular linker search paths. YES owns the directories it creates. YES doesn't own any directories it shouldn't. YES no duplicates in %files. YES file permissions are appropriate. YES no scriptlets present. YES code, not content. YES documentation is small, so no -docs subpackage is necessary. YES %docs are not necessary for the proper functioning of the package. YES no headers. YES no pkgconfig files. YES no libtool .la droppings.
I'm going to add rarpd into EPEL-6, since there is some demand for it. Therefore I'd like to finish this ancient review. Jirka, would you be willing to look at it again if there is everything ok? (In reply to Jiri Popelka from comment #1) > NO source files match upstream. > - The source URL is not accessible. > I think Debian's ftp can be used instead > http://ftp.debian.org/debian/pool/main/r/rarpd/ That one doesn't include the same tarball AFAICT, but this one does: ftp://ftp.fi.netbsd.org/.m/mirrors1/ftp.inr.ac.ru/ip-routing/dhcp.bootp.rarp/rarpd-%{version}.tar.gz > NO License text included in package. Added manually, since upstream is dead. > NO rpmlint is silent. > rarpd.x86_64: W: no-url-tag Upstream is dead with no official page, except man pages and package databases. I have no idea how to fix it. > rarpd.x86_64: W: conffile-without-noreplace-flag /etc/rc.d/init.d/rarpd > rarpd.x86_64: E: executable-marked-as-config-file /etc/rc.d/init.d/rarpd > - do not mark initscript with %config > - use %{_initddir} instead of /etc/rc.d/init.d We use systemd unit files now. > NO final provides and requires look sane. > - Prereq should be replaced with Requires Fixed. NEW SRPM: http://pkgs.fedoraproject.org/cgit/rarpd.git/tree/rarpd.spec KOJI BUILD: http://koji.fedoraproject.org/koji/buildinfo?buildID=425941
Everything looks good to me. APPROVED!
Package Change Request ====================== Package Name: rarpd New Branches: el6 Owners: hhorak
Git done (by process-git-requests).
rarpd-ss981107-42.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rarpd-ss981107-42.el6
rarpd-ss981107-42.el6 has been pushed to the Fedora EPEL 6 testing repository.
rarpd-ss981107-42.el6 has been pushed to the Fedora EPEL 6 stable repository.