Bug 2263560 - Review Request: ethq - Ethernet NIC Queue stats viewer
Summary: Review Request: ethq - Ethernet NIC Queue stats viewer
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/isc-projects/ethq
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-09 18:33 UTC by Petr Menšík
Modified: 2024-02-10 05:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 7005486 to 7005487 (1.26 KB, patch)
2024-02-10 05:14 UTC, Fedora Review Service
no flags Details | Diff

Description Petr Menšík 2024-02-09 18:33:56 UTC
Spec URL: https://pemensik.fedorapeople.org/ethq.spec
SRPM URL: https://pemensik.fedorapeople.org/ethq-0.6.3-1.fc38.src.rpm

Description:
Displays an auto-updating per-second count of the number of packets and
bytes being handled by each specified NIC, and on multi-queue NICs shows
the per-queue statistics too.

Fedora Account System Username: pemensik

Comment 1 Petr Menšík 2024-02-09 18:33:59 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=113245316

Comment 2 Petr Menšík 2024-02-09 18:52:50 UTC
Oh, packaged version is crashing to me, but just make && ./ethq does not.

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7ccd4ae in std::local_Rb_tree_decrement (__x=0x55555557f708 <StringsetParser::parsers[abi:cxx11]+8>)
    at ../../../../../libstdc++-v3/src/c++98/tree.cc:98
Downloading source file /usr/src/debug/gcc-13.2.1-4.fc38.x86_64/obj-x86_64-redhat-linux/x86_64-redhat-linux/libstdc++-v3/src/c++98/../../../../../libstdc++-v3/src/c++98/tree.cc
98              && __x->_M_parent->_M_parent == __x)                                                                  
(gdb) bt
#0  0x00007ffff7ccd4ae in std::local_Rb_tree_decrement (__x=0x55555557f708 <StringsetParser::parsers[abi:cxx11]+8>)
    at ../../../../../libstdc++-v3/src/c++98/tree.cc:98
#1  std::_Rb_tree_decrement (__x=__x@entry=0x55555557f708 <StringsetParser::parsers[abi:cxx11]+8>)
    at ../../../../../libstdc++-v3/src/c++98/tree.cc:123
#2  0x000055555555fcb0 in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> >::operator-- (this=<synthetic pointer>)
    at /usr/include/c++/13/bits/stl_tree.h:302
#3  std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> > >::_M_get_insert_unique_pos(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) [clone .constprop.0] (__k="fsl_dpaa2_eth", this=<optimized out>) at /usr/include/c++/13/bits/stl_tree.h:2127
#4  0x000055555555ef96 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> > >::_M_get_insert_hint_unique_pos (this=0x55555557f700 <StringsetParser::parsers[abi:cxx11]>, 
    __k="fsl_dpaa2_eth", __position=...) at /usr/include/c++/13/bits/stl_tree.h:2256
#5  std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> > >::_M_emplace_hint_unique<std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>, std::tuple<> >(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> >, std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>&&, std::tuple<>&&) (
    this=0x55555557f700 <StringsetParser::parsers[abi:cxx11]>, __pos=...) at /usr/include/c++/13/bits/stl_tree.h:2463
#6  std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, StringsetParser*, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, StringsetParser*> > >::operator[] (
    this=0x55555557f700 <StringsetParser::parsers[abi:cxx11]>, __k=...) at /usr/include/c++/13/bits/stl_map.h:513
#7  StringsetParser::save (name=..., this=<optimized out>) at /home/pemensik/upstream/ethq/ethq-0_6_3/parser.cc:29
#8  StringsetParser::save (this=this@entry=0x55555557f800 <nxp_daap2>, drivers=...)
    at /home/pemensik/upstream/ethq/ethq-0_6_3/parser.cc:24
#9  0x000055555555f1ce in StringsetParser::StringsetParser (drivers=..., this=<optimized out>)
    at /home/pemensik/upstream/ethq/ethq-0_6_3/parser.cc:19
#10 RegexParser::RegexParser (this=<optimized out>, drivers=..., total=..., queue=..., this=<optimized out>, 
    drivers=..., total=..., queue=...) at /home/pemensik/upstream/ethq/ethq-0_6_3/parser.cc:54
--Type <RET> for more, q to quit, c to continue without paging--
#11 0x000055555555ff12 in _sub_I_65535_0.0 ()
#12 0x00007ffff7a49cc4 in call_init (env=<optimized out>, argv=0x7fffffffddc8, argc=1) at ../csu/libc-start.c:145
#13 __libc_start_main_impl (main=0x55555555c4f0 <main(int, char**)>, argc=1, argv=0x7fffffffddc8, 
    init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffddb8)
    at ../csu/libc-start.c:347
#14 0x0000555555560de5 in _start ()

Comment 3 Petr Menšík 2024-02-09 20:39:03 UTC
Spec URL: https://github.com/pemensik/ethq/raw/fedora/ethq.spec
SRPM URL: https://pemensik.fedorapeople.org/ethq-0.6.3-2.fc38.src.rpm

Disabled LTO and added very simple %check

Comment 4 Petr Menšík 2024-02-09 20:56:06 UTC
Made a new scratch build, this time not crashing when started hopefully.
https://koji.fedoraproject.org/koji/taskinfo?taskID=113252401

Comment 5 Fedora Review Service 2024-02-10 05:14:16 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7005487
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263560-ethq/fedora-rawhide-x86_64/07005487-ethq/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-02-10 05:14:49 UTC
Created attachment 2016145 [details]
The .spec file difference from Copr build 7005486 to 7005487

Comment 7 Fedora Review Service 2024-02-10 05:14:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7005486
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263560-ethq/fedora-rawhide-x86_64/07005486-ethq/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.