Bug 2263582 - Review Request: rust-env_filter - Filter log events using environment variables
Summary: Review Request: rust-env_filter - Filter log events using environment variables
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-09 22:13 UTC by Dorinda
Modified: 2024-02-24 16:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-22 02:23:50 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Dorinda 2024-02-09 22:13:16 UTC
Spec URL: https://raw.githubusercontent.com/dorindabassey/env_filter-copr/main/rust-env_filter.spec
SRPM URL: https://github.com/dorindabassey/env_filter-copr/raw/main/rust-env_filter-0.1.0-1.fc40.src.rpm
Description:Filter log events using environment variables
Fedora Account System Username:dorinda

Comment 1 Fabio Valentini 2024-02-09 23:35:17 UTC
The %changelog section appears to be mangled.

Looks like Tito does not support rpmautospec? If that is the case, please do not use Tito to prepare the files for this review

Comment 3 Fabio Valentini 2024-02-12 15:56:50 UTC
Thanks - can you link the plain-text file please? The Spec URL points at an HTML page.
Should be as simple as replacing "blob" with "raw" in the URL.
If the link doesn't point at the plain-text file, automated tools cannot parse it.

Comment 5 Fabio Valentini 2024-02-15 17:15:15 UTC
[fedora-review-service-build]

Comment 6 Fabio Valentini 2024-02-18 15:18:45 UTC
[fedora-review-service-build]

Let's try that again ...

Comment 7 Fabio Valentini 2024-02-19 16:22:28 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please also request dist-git branches for f40, f39, f38, and epel9.
I will need this package in all branches in order to update the env_logger crate to v0.11.

Comment 8 Fedora Review Service 2024-02-19 16:22:44 UTC
Hello @dorinda,
since this is your first Fedora package, you need to get sponsored by a package
sponsor before it can be accepted.

A sponsor is an experienced package maintainer who will guide you through
the processes that you will follow and the tools that you will use as a future
maintainer. A sponsor will also be there to answer your questions related to
packaging.

You can find all active sponsors here:
https://docs.pagure.org/fedora-sponsors/

I created a sponsorship request for you:
https://pagure.io/packager-sponsors/issue/629
Please take a look and make sure the information is correct.

Thank you, and best of luck on your packaging journey.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

Comment 9 Fabio Valentini 2024-02-19 16:27:20 UTC
Ah, I just noticed you're not in the packager group yet.
Do you already have somebody who will sponsor you?

Comment 10 Dorinda 2024-02-20 09:22:11 UTC
Thank you for the sponsorship request Fabio,


(In reply to Fabio Valentini from comment #9)
> Ah, I just noticed you're not in the packager group yet.
> Do you already have somebody who will sponsor you?

Rishi offered to sponsor me in the ticket

 
> Please also request dist-git branches for f40, f39, f38, and epel9.
> I will need this package in all branches in order to update the env_logger
> crate to v0.11.

I assume I can do this after I'm being sponsored into the packager group right?

Comment 11 Debarshi Ray 2024-02-20 13:56:07 UTC
(In reply to Fedora Review Service from comment #8)
> I created a sponsorship request for you:
> https://pagure.io/packager-sponsors/issue/629

Done!  Welcome to Fedora, Dorinda.

Comment 12 Debarshi Ray 2024-02-20 14:02:31 UTC
(In reply to Dorinda from comment #10)
>  
> > Please also request dist-git branches for f40, f39, f38, and epel9.
> > I will need this package in all branches in order to update the env_logger
> > crate to v0.11.
> 
> I assume I can do this after I'm being sponsored into the packager group
> right?

Yes, you can now do:

$ fedpkg request-repo rust-env_filter 2263582

$ fedpkg request-branch --repo rust-env_filter f40 f39 f38 epel9


See:
"Add Package to Source Code Management"
https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process_for_New_Contributors/

Comment 13 Fedora Admin user for bugzilla script actions 2024-02-21 17:19:10 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-env_filter

Comment 14 Dorinda 2024-02-21 17:26:27 UTC
Thank you Rishi. Done now :)

Comment 15 Fedora Update System 2024-02-22 02:18:55 UTC
FEDORA-2024-39d6b4a5d2 (rust-env_filter-0.1.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-39d6b4a5d2

Comment 16 Fedora Update System 2024-02-22 02:23:50 UTC
FEDORA-2024-39d6b4a5d2 (rust-env_filter-0.1.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-02-22 02:37:46 UTC
FEDORA-2024-1426470068 (rust-env_filter-0.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1426470068

Comment 18 Fedora Update System 2024-02-22 02:41:51 UTC
FEDORA-2024-1426470068 (rust-env_filter-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fabio Valentini 2024-02-24 16:26:57 UTC
Thank you for requesting all the branches!

I see that you built the package for f39 and f38 too (not epel9?), but for stable releases, updates are not created automatically. Please submit them via the updates system.


Note You need to log in before you can comment on or make changes to this bug.