sg3_utils needs some love. Spec is not fedora compliant (static libs, .la libs).
It also could use an update to 1.25 which uses automake and will make the spec
file simpler. 1.25 also introduces the very useful 'sg_raw' utility.

Will take care of it next week.

Read ya, Phil

Ok, did some final cleanups to the specfile and removed the static libraries.
The remaining rpmlint warnings are either not fixable or plainly wrong for this
package (libs package doesn't contain any documentation and sg3_utils-devel only
needs the sg3_utils-libs package to work properly).

Building sg3_utils-1.25-3 in rawhide as i write this, so should land in the next
couple of days in the tree.

Let me know if there is anything else you see that should be changed.

Thanks,

Read ya, Phil

Looking good. couple of minor non-blocking nitpicks

- is the "Provides: sg_utils' still useful ?

- instead of removing the *.a files, simply configure with '--disable-static'
(you still need to keep the removal of *.la files though).

This review is APPROVED.

I just figured i'd keep the Provides in, but i checked today once more and we
never actually shipped sg_utils in Fedora or Red Hat, so i'll just drop it.

And good point about the 2nd thing, will add that in the new build as well.

Thanks Denis!

Read ya, Phil