Bug 226414 - Merge Review: sg3_utils
Merge Review: sg3_utils
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Denis Leroy
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 15:58 EST by Nobody's working on this, feel free to take it
Modified: 2008-03-28 10:07 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-03-28 06:23:22 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
denis: fedora‑review+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 15:58:45 EST
Fedora Merge Review: sg3_utils

Initial Owner: pknirsch@redhat.com
Comment 1 Denis Leroy 2008-03-10 07:39:20 EDT
sg3_utils needs some love. Spec is not fedora compliant (static libs, .la libs).
It also could use an update to 1.25 which uses automake and will make the spec
file simpler. 1.25 also introduces the very useful 'sg_raw' utility.

Comment 2 Phil Knirsch 2008-03-20 15:01:41 EDT
Will take care of it next week.

Read ya, Phil
Comment 3 Phil Knirsch 2008-03-27 10:30:09 EDT
Ok, did some final cleanups to the specfile and removed the static libraries.
The remaining rpmlint warnings are either not fixable or plainly wrong for this
package (libs package doesn't contain any documentation and sg3_utils-devel only
needs the sg3_utils-libs package to work properly).

Building sg3_utils-1.25-3 in rawhide as i write this, so should land in the next
couple of days in the tree.

Let me know if there is anything else you see that should be changed.


Read ya, Phil
Comment 4 Denis Leroy 2008-03-28 06:21:25 EDT
Looking good. couple of minor non-blocking nitpicks

- is the "Provides: sg_utils' still useful ?

- instead of removing the *.a files, simply configure with '--disable-static'
(you still need to keep the removal of *.la files though).

This review is APPROVED.
Comment 5 Phil Knirsch 2008-03-28 10:07:02 EDT
I just figured i'd keep the Provides in, but i checked today once more and we
never actually shipped sg_utils in Fedora or Red Hat, so i'll just drop it.

And good point about the 2nd thing, will add that in the new build as well.

Thanks Denis!

Read ya, Phil

Note You need to log in before you can comment on or make changes to this bug.