Fedora Merge Review: shadow-utils http://cvs.fedora.redhat.com/viewcvs/devel/shadow-utils/ Initial Owner: pvrabec
rpmlint on srpm: shadow-utils.src: W: mixed-use-of-spaces-and-tabs (spaces: line 140, tab: line 66) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Minor. rpmlint on rpms: shadow-utils.i386: E: non-readable /usr/sbin/userdel 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/userdel 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: non-readable /usr/sbin/groupdel 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupdel 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: non-readable /usr/sbin/groupmems 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupmems 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: setuid-binary /usr/bin/newgrp root 04755 The file is setuid, this may be dangerous, especially if this file is setuid root. shadow-utils.i386: E: non-standard-executable-perm /usr/bin/newgrp 04755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: non-readable /usr/sbin/groupadd 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupadd 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: setuid-binary /usr/bin/chage root 04755 The file is setuid, this may be dangerous, especially if this file is setuid root. shadow-utils.i386: E: non-standard-executable-perm /usr/bin/chage 04755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: non-readable /etc/default/useradd 0600 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-readable /usr/sbin/usermod 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/usermod 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: setuid-binary /usr/bin/gpasswd root 04755 The file is setuid, this may be dangerous, especially if this file is setuid root. shadow-utils.i386: E: non-standard-executable-perm /usr/bin/gpasswd 04755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: E: non-readable /usr/sbin/useradd 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/useradd 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. shadow-utils.i386: W: file-not-utf8 /usr/share/doc/shadow-utils-4.1.0/HOWTO The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). shadow-utils.i386: E: non-readable /usr/sbin/groupmod 0750 The file can't be read by everybody. If this is expected (for security reasons), contact your rpmlint distributor to get it added to the list of exceptions for your distro (or add it to your local configuration if you installed rpmlint from the source tarball). shadow-utils.i386: E: non-standard-executable-perm /usr/sbin/groupmod 0750 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. The non-standard perms make sense to me for this package. The file-not-utf8 for th HOWTO is a simple fix, and worth doing. License tag should be BSD and GPLv2+. Otherwise, no additional blockers.
Any updates?
Reviewed newest rawhide SRPM. Still has space-and-tabs issues, and needs a license tag fix.
Ping?
fixed * Mon Jan 19 2009 Peter Vrabec <pvrabec> 2:4.1.2-11 - fix license tag (#226416) - get rid of tabs in spec file (#226416) - convert HOWTO to UTF8 (#226416)
Looks great, APPROVED. Thanks!