Bug 2264164 - Review Request: golang-github-foxcpp-mockdns - Boilerplate for testing of code involving DNS lookups, including unholy hacks to redirect net.Lookup* calls
Summary: Review Request: golang-github-foxcpp-mockdns - Boilerplate for testing of cod...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2175110
TreeView+ depends on / blocked
 
Reported: 2024-02-14 10:05 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2024-02-14 11:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-14 11:36:35 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Dominik 'Rathann' Mierzejewski 2024-02-14 10:05:23 UTC
Spec URL: https://rathann.fedorapeople.org/review/golang-github-foxcpp-mockdns/golang-github-foxcpp-mockdns.spec
SRPM URL: https://rathann.fedorapeople.org/review/golang-github-foxcpp-mockdns/golang-github-foxcpp-mockdns-1.1.0-1.fc41.src.rpm
Description: Boilerplate for testing of code involving DNS lookups, including unholy hacks to redirect net.Lookup* calls

Fedora Account System Username: rathann

Comment 1 Dominik 'Rathann' Mierzejewski 2024-02-14 10:06:31 UTC
Credit goes to Mikel for the initial package in bug 2105447 .

Comment 2 Fedora Review Service 2024-02-14 10:08:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7013599
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264164-golang-github-foxcpp-mockdns/fedora-rawhide-x86_64/07013599-golang-github-foxcpp-mockdns/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Dominik 'Rathann' Mierzejewski 2024-02-14 10:26:40 UTC
Builds fine in COPR: https://copr.fedorainfracloud.org/coprs/rathann/helm/build/7013821/

Comment 4 Mikel Olasagasti Uranga 2024-02-14 10:43:22 UTC
Spec is correct, but Summary is too large, reduce it before importing.

I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 5 Fedora Admin user for bugzilla script actions 2024-02-14 11:26:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-foxcpp-mockdns

Comment 6 Fedora Update System 2024-02-14 11:34:34 UTC
FEDORA-2024-87bb9f8086 (golang-github-foxcpp-mockdns-1.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-87bb9f8086

Comment 7 Fedora Update System 2024-02-14 11:36:35 UTC
FEDORA-2024-87bb9f8086 (golang-github-foxcpp-mockdns-1.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.