Red Hat Bugzilla – Bug 226419
Merge Review: sip
Last modified: 2011-09-23 14:46:57 EDT
Fedora Merge Review: sip
Initial Owner: email@example.com
Below are the issues I found. I will attach a full review shortly.
- License field in spec is correct
sipgen/parser.c is GPLv3+ with exceptions
sipgen/parser.h is GPLv3+ with exceptions
A quick IRC discussion indicated that this likely needs to appear in the License field somewhere. I'm hoping spot gets back to me for confirmation about it to be sure, though perhaps it would be better to just ask legal to be extra certain.
- License files installed when any subpackage combination is installed
sip-macros package does not pull in license files
It looks like you create macros.sip yourself based on the program's API version. What license does it have? Can you include that license along with the sip-macros package?
- Sources match upstream unless altered to fix permissibility issues
Upstream MD5: No longer on upstream's server
Your MD5: 0a591ef6e59aa16e56822d3eb9fe21b8 sip-4.10.5.tar.gz
Unfortunately, upstream seems to clean out old tarballs quite frequently. I wouldn't block the review because of that, though.
- Each %files section contains %defattr
The python3 packages lack %defattr macros
Please add %defattr macros to the python3 packages' %files sections.
I hope that helps!
Created attachment 460953 [details]
Review for F14 package sip-4.10.5-2.fc14
git's master branch has the latest sip (which should be available upstream), and I *think* defattr fixed too, fwiw.
nvm, defattr fail there too. :( fixing that now, easyfix.
The word from spot is that the License field should read "GPLv2 or GPLv3 and (GPLv3+ with exceptions)". The spec file should also contain a comment explaining the bison files' license.
OK, updated License: accordingly in master/ branch.
Stick a fork in this sucker, finally.