Spec URL: https://trix.fedorapeople.org/rocm-validation-suite.spec SRPM URL: https://trix.fedorapeople.org/rocm-validation-suite-6.0.2-1.fc40.src.rpm The ROCm Validation Suite (RVS) is a system validation and diagnostics tool for monitoring, stress testing, detecting and troubleshooting issues that affects the functionality and performance of AMD GPU(s) operating in a high-performance/AI/ML computing environment. RVS is enabled using the ROCm software stack on a compatible software and hardware platform. Reproducible: Always
This package is only intended for testing. I do not believe it was ever ment to be packaged and has a lot of rough parts so I hope it will get a pass on the usual expected quality. I expect the package to be used by users to test their particular card and report problems or by some to be defined fedora c/i.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7015749 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264206-rocm-validation-suite/fedora-rawhide-x86_64/07015749-rocm-validation-suite/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://trix.fedorapeople.org/rocm-validation-suite.spec SRPM URL: https://trix.fedorapeople.org/rocm-validation-suite-6.0.2-1.fc41.src.rpm Updated for the llvm17 change
I tried out the src.rpm The line in the spec: %global build_cxxflags %(echo %{optflags} | sed -e 's/-fcf-protection// -e 's/-fcf-protection//' -e 's/-ffat-lto-objects//') is missing an aphostrophe at the end of the second sed: %global build_cxxflags %(echo %{optflags} | sed -e 's/-fcf-protection//' -e 's/-fcf-protection//' -e 's/-ffat-lto-objects//') After fixing this locally and building the package I can confirm that rvs ran through without errors on my gfx900
Created attachment 2021523 [details] The .spec file difference from Copr build 7015749 to 7156062
Copr build: https://copr.fedorainfracloud.org/coprs/build/7156062 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264206-rocm-validation-suite/fedora-rawhide-x86_64/07156062-rocm-validation-suite/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The spec has been fixed Thanks!
Hello, do you still need help with the package review?