Spec URL: https://salimma.fedorapeople.org/specs/helvum.spec SRPM URL: https://salimma.fedorapeople.org/specs/helvum-0.5.1-1.fc39.src.rpm Description: A GTK patchbay for pipewire. Fedora Account System Username: salimma
1. The spec file uploaded separately doesn't match the spec file in the SRPM, please make sure they match. > URL: https://gitlab.freedesktop.org/pipewire/helvum > Source: https://gitlab.freedesktop.org/pipewire/helvum/-/archive/%{version}/helvum-%{version}.tar.gz 2. You can replace this with: ``` URL: https://gitlab.freedesktop.org/pipewire/helvum Source: %{url}/-/archive/%{version}/helvum-%{version}.tar.gz ``` To make it more concise. 3. You might want to validate the AppStream metadata with appstream as well, it is now used everywhere instead of appstream-glib (with one exception): ``` BuildRequires: appstream (...) appstreamcli validate --no-net path-to-file ```
Side note: This is technically a package rename-review, but it will not require adding Provides / Obsoletes, since the name of the built binary package "helvum" will stay the same. Only the name of the binary package will be different.
(In reply to Fabio Valentini from comment #1) > 1. The spec file uploaded separately doesn't match the spec file in the > SRPM, please make sure they match. > I probably forgot to regenerate before uploading, sorry > > URL: https://gitlab.freedesktop.org/pipewire/helvum > > Source: https://gitlab.freedesktop.org/pipewire/helvum/-/archive/%{version}/helvum-%{version}.tar.gz > > 2. You can replace this with: > > ``` > URL: https://gitlab.freedesktop.org/pipewire/helvum > Source: %{url}/-/archive/%{version}/helvum-%{version}.tar.gz > ``` > Ah, of course > To make it more concise. > > 3. You might want to validate the AppStream metadata with appstream as well, > it is now used everywhere instead of appstream-glib (with one exception): > > ``` > BuildRequires: appstream > (...) > appstreamcli validate --no-net path-to-file > ``` Will update, thanks
Spec and SRPM updated. I guess the review service is not running today?
> > 3. You might want to validate the AppStream metadata with appstream as well, > > it is now used everywhere instead of appstream-glib (with one exception): > > > > ``` > > BuildRequires: appstream > > (...) > > appstreamcli validate --no-net path-to-file > > ``` > Will update, thanks I wrote *as well* because I suggested doing *both*. Using appstream-util from appstream-glib is still mandatory according to the Packaging Guidelines, even if that is no longer used by either GNOME Software or Plasma Discover. Please restore the appstream-util validation before importing the package. Other than that, package looks good to me now. You might also want to retire rust-helvum as soon as this package lands in f41 and f40.
(In reply to Fabio Valentini from comment #5) > > > 3. You might want to validate the AppStream metadata with appstream as well, > > > it is now used everywhere instead of appstream-glib (with one exception): > > > > > > ``` > > > BuildRequires: appstream > > > (...) > > > appstreamcli validate --no-net path-to-file > > > ``` > > Will update, thanks > > I wrote *as well* because I suggested doing *both*. > woops! will do We should probably try and get the packaging guidelines updated? And yes, will retire rust-helvum for the branches we can still retire it for, thanks
The Pagure repository was created at https://src.fedoraproject.org/rpms/helvum
FEDORA-2024-9c1f2988ab (helvum-0.5.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9c1f2988ab
FEDORA-2024-9c1f2988ab (helvum-0.5.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-13a770c50b (helvum-0.5.1-1.fc40, rust-libspa-0.7.2-3.fc40, and 2 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-13a770c50b
FEDORA-2024-13a770c50b (helvum-0.5.1-1.fc40, rust-libspa-0.7.2-3.fc40, and 2 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-af514c0193 (helvum-0.5.1-1.fc39, rust-ashpd-0.6.2-4.fc39, and 5 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-af514c0193
FEDORA-2024-b320377014 (helvum-0.5.1-1.fc38, rust-libspa-0.7.2-3.fc38, and 4 more) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b320377014
FEDORA-2024-af514c0193 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-af514c0193 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-af514c0193 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b320377014 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b320377014 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b320377014 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-af514c0193 (helvum-0.5.1-1.fc39, rust-ashpd-0.6.2-4.fc39, and 5 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b320377014 (helvum-0.5.1-1.fc38, rust-libspa-0.7.2-3.fc38, and 4 more) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.