Bug 2264486 - Review Request: rust-lsp-server - Generic LSP server scaffold
Summary: Review Request: rust-lsp-server - Generic LSP server scaffold
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/lsp-server
Whiteboard:
Depends On:
Blocks: 2264490
TreeView+ depends on / blocked
 
Reported: 2024-02-16 00:08 UTC by Michel Lind
Modified: 2024-02-17 03:02 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-17 03:02:44 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-02-16 00:08:54 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-lsp-server.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-lsp-server-0.7.5-1.fc39.src.rpm

Description:
Generic LSP server scaffold.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2024-02-16 00:10:35 UTC
note: 0.7.6 is out, but needs an updated lsp-types while 0.7.5 uses the version currently depended on by helix, so we can update them all later

Comment 2 Fedora Review Service 2024-02-16 00:14:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7021286
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264486-rust-lsp-server/fedora-rawhide-x86_64/07021286-rust-lsp-server/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-02-16 19:23:01 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (0.7.5 is packaged, 0.7.6 requires newer versions of dependencies than what is available in Fedora ATM)
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files (manually included from upstream, PR submitted to include them in the future)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2024-02-16 21:29:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lsp-server

Comment 5 Fedora Update System 2024-02-17 02:59:39 UTC
FEDORA-2024-29bcccf9c9 (rust-lsp-server-0.7.5-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-29bcccf9c9

Comment 6 Fedora Update System 2024-02-17 03:02:44 UTC
FEDORA-2024-29bcccf9c9 (rust-lsp-server-0.7.5-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.