Fedora Merge Review: syslinux http://cvs.fedora.redhat.com/viewcvs/devel/syslinux/ Initial Owner: pjones
Having somewhat of a vested interest in syslinux, I'll review this one also.
Initial scan... E: syslinux tag-not-utf8 %changelog Encodings as appearing from "file" do seem odd. file syslinux.spec syslinux.spec: ISO-8859 make commands text W: syslinux no-url-tag This should probably be a Url: http://syslinux.zytor.com E: syslinux non-utf8-spec-file syslinux.spec See earlier comments on file format. W: syslinux unversioned-explicit-provides syslinux-devel Probably should add the version here. E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib/libsyslinux* E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.com E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.exe E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.c32 E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.bin E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.0 E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/memdisk E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/*.pl E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/mkdiskimage E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/syslinux E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/syslinux-nomtools E: syslinux hardcoded-library-path in %{_prefix}/lib/syslinux/com32 I'm not entirely sure what Fedora Extras guidelines say here for packages that are exclusively 32bit, but I would expect to see %{_libdir} here. Maybe syslinux gets an exception? W: syslinux mixed-use-of-spaces-and-tabs (spaces: line 59, tab: line 58) This should be relatively easy to fix and isn't a major problem. ---- Other comments: (+) Biuldroot, license, and other header info looks good with the exception of the missing URL. ExclusiveArch is right for what syslinux supports, etc. (?) Can Requires: /usr/include/gnu/stubs-32.h be replaced by the package that provides it (glibc-devel) or is there a reason for doing this? (?) Doesn't specify a specific version of perl or netpbm-progs, though specifying some minimum version would be desirable. (+) Files section looks fine.
Passing this back to pjones for fixing, if anyone else on fedora-review sees anything else that they would like to point out, please do.
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket: https://fedorahosted.org/fesco/ticket/1269 If you don't know what merge reviews are about, please see: https://fedoraproject.org/wiki/Merge_Reviews How to handle this bug is left to the discretion of the package maintainer.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23
This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.