Fedora Merge Review: sysstat http://cvs.fedora.redhat.com/viewcvs/devel/sysstat/ Initial Owner: varekova
Source: W: sysstat macro-in-%changelog _includedir Arch: W: sysstat log-files-without-logrotate /var/log/sa W: sysstat dangerous-command-in-%preun rm W: sysstat dangerous-command-in-%trigger cp W: sysstat service-default-enabled /etc/rc.d/init.d/sysstat E: sysstat subsys-not-used /etc/rc.d/init.d/sysstat md5sum ok, but new version was released. Defattr: 4 parametres Myabe you can rename patches in numeric order.
There should be a major changes which I want to discuss with upstream, so it will take some time to fix these problems.
All problems should be fixed in sysstat-8.0.2-2.fc9. Could you please look at it?
> sysstat.i386: W: log-files-without-logrotate /var/log/sa problem? > sysstat.i386: W: dangerous-command-in-%preun rm It's removing logs with sysstat good solution? > sysstat.i386: W: service-default-enabled /etc/rc.d/init.d/sysstat that's ok > sysstat.i386: E: subsys-not-used /etc/rc.d/init.d/sysstat You don't use locks, that's also ok? Use macros from /usr/lib/rpm/i686-linux/macros var = %_localstatedir etc = %_sysconfdir
(In reply to comment #4) > > sysstat.i386: W: log-files-without-logrotate /var/log/sa > problem? This is OK becouse of sysstat uses its own version of logrotate > > sysstat.i386: W: dangerous-command-in-%preun rm > It's removing logs with sysstat good solution? Yes, there is no problem. > > sysstat.i386: W: service-default-enabled /etc/rc.d/init.d/sysstat > that's ok yes, it is not standard daemon. > > sysstat.i386: E: subsys-not-used /etc/rc.d/init.d/sysstat > You don't use locks, that's also ok? Again - no problem because of it is not standard daemon. > Use macros from /usr/lib/rpm/i686-linux/macros > var = %_localstatedir > etc = %_sysconfdir Thanks, fixed (sysstat-8.0.2-3.fc9).
Ok