Bug 226451 - Merge Review: sysstat
Merge Review: sysstat
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:04 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version: sysstat-8.0.2-3.fc9
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-09 05:48:24 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmaslano: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:04:20 EST
Fedora Merge Review: sysstat

http://cvs.fedora.redhat.com/viewcvs/devel/sysstat/
Initial Owner: varekova@redhat.com
Comment 1 Marcela Mašláňová 2007-02-23 06:45:11 EST
Source:
W: sysstat macro-in-%changelog _includedir
Arch:
W: sysstat log-files-without-logrotate /var/log/sa
W: sysstat dangerous-command-in-%preun rm
W: sysstat dangerous-command-in-%trigger cp
W: sysstat service-default-enabled /etc/rc.d/init.d/sysstat
E: sysstat subsys-not-used /etc/rc.d/init.d/sysstat

md5sum ok, but new version was released.
Defattr: 4 parametres

Myabe you can rename patches in numeric order.
Comment 2 Ivana Varekova 2007-03-05 03:28:06 EST
There should be a major changes which I want to discuss with upstream, so it
will take some time to fix these problems. 
Comment 3 Ivana Varekova 2007-11-08 10:03:24 EST
All problems should be fixed in sysstat-8.0.2-2.fc9. 
Could you please look at it?
Comment 4 Marcela Mašláňová 2007-11-08 10:26:06 EST
> sysstat.i386: W: log-files-without-logrotate /var/log/sa
problem?
> sysstat.i386: W: dangerous-command-in-%preun rm
It's removing logs with sysstat good solution?
> sysstat.i386: W: service-default-enabled /etc/rc.d/init.d/sysstat
that's ok
> sysstat.i386: E: subsys-not-used /etc/rc.d/init.d/sysstat
You don't use locks, that's also ok?

Use macros from /usr/lib/rpm/i686-linux/macros
var = %_localstatedir
etc = %_sysconfdir
Comment 5 Ivana Varekova 2007-11-09 05:46:32 EST
(In reply to comment #4)
> > sysstat.i386: W: log-files-without-logrotate /var/log/sa
> problem?
This is OK becouse of sysstat uses its own version of logrotate

> > sysstat.i386: W: dangerous-command-in-%preun rm
> It's removing logs with sysstat good solution?
Yes, there is no problem.

> > sysstat.i386: W: service-default-enabled /etc/rc.d/init.d/sysstat
> that's ok
yes, it is not standard daemon.

> > sysstat.i386: E: subsys-not-used /etc/rc.d/init.d/sysstat
> You don't use locks, that's also ok?
Again - no problem because of it is not standard daemon.

> Use macros from /usr/lib/rpm/i686-linux/macros
> var = %_localstatedir
> etc = %_sysconfdir
Thanks, fixed (sysstat-8.0.2-3.fc9).
Comment 6 Marcela Mašláňová 2007-11-09 05:48:24 EST
Ok

Note You need to log in before you can comment on or make changes to this bug.