Fedora Merge Review: system-config-lvm http://cvs.fedora.redhat.com/viewcvs/devel/system-config-lvm/ Initial Owner: jparsons
need some SPEC cleanups 1) avoid makeinstall usage http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 2) update buildroot tag as said below http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 3) use make %{?_smp_mflags} rpmlint said system-config-lvm.src: W: mixed-use-of-spaces-and-tabs (spaces: line 100, tab: line 35) system-config-lvm.src: W: summary-ended-with-dot A utility for graphically configuring Logical Volumes. system-config-lvm.src: W: invalid-license GPL system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/fdisk_wrapper.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/VolumeGroup.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/pixmaps/VG.xpm 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/pixmaps/PV.xpm 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/pixmaps/UV.xpm 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Segment.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Partition.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/ExtentBlock.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/execute.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/renderer.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/utilities.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Cluster.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/BlockDevice.py 0640 system-config-lvm.noarch: W: no-dependency-on usermode system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/lvmui_constants.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/lvm_model.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/parted_wrapper.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Volume.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Filesystem.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/cylinder_items.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/PhysicalVolume.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/pixmaps/grad3.xpm 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/pixmaps/LV.xpm 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/CommandHandler.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/CommandError.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Volume_Tab_View.py 0640 system-config-lvm.noarch: E: non-executable-script /usr/share/system-config-lvm/Volume_Tab_View.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Properties_Renderer.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Fstab.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/InputController.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/WaitMsg.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/LogicalVolume.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/BlockDeviceModel.py 0640 system-config-lvm.noarch: E: non-readable /usr/share/system-config-lvm/Multipath.py 0640 system-config-lvm.noarch: W: summary-ended-with-dot A utility for graphically configuring Logical Volumes. system-config-lvm.noarch: W: invalid-license GPL system-config-lvm.noarch: W: conffile-without-noreplace-flag /etc/pam.d/system-config-lvm system-config-lvm.noarch: W: conffile-without-noreplace-flag /etc/security/console.apps/system-config-lvm Update package. Better to provide new SPEC and SRPM links for this package before actually committing in CVS.
SRPM and spec file at http://people.redhat.com/jparsons/downloads/s-c-lvm/ rpmlint -v produces no warnings now.
No permission to download SRPM
ping?
http://people.redhat.com/rmccabe/s-c-lvm/
with updated SPEC, system-config-lvm.noarch: E: invalid-desktopfile /usr/share/applications/system-config-lvm.desktop .desktop file is not valid, check with desktop-file-validate system-config-lvm.src: W: strange-permission system-config-lvm.spec 0600 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions.
Owner of this package is not responding here.
Hey - So sorry. I'm here. Will look into above comment about file permissions and write again today.
Ok. looks like some changes was already committed in rawhide without notifying here for further review. Based on today's rawhide spec, + rpmlint only gave system-config-lvm.noarch: W: no-dependency-on usermode ==> ok + all issues asked to fix since comment#1 looks fixed now in rawhide package. + Package now follows packaging guidelines. APPROVED.