Fedora Merge Review: system-config-netboot http://cvs.fedora.redhat.com/viewcvs/devel/system-config-netboot/ Initial Owner: fleite
Just some comments on this spec file - Use %defattr(-,root,root,-) instead of %defattr(-,root,root) - Use parallel make (make %{?_smp_mflags}) - Is there a reason that %makeinstall is used? https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
cc'ing current owner of this package jreznik
Thank you for cc'ing me here, issues are fixed now in devel. I'm only not sure if we really need smp_flags - it's noarch package.
Created attachment 327623 [details] patch to silent rpmlint output on srpm
Still there are rpmlint output not silent on rpms system-config-netboot.noarch: E: non-executable-script /usr/share/system-config-netboot/pxeosdialog.py 0644 system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/netboot_gtk.py 0750 system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/netboot_gtk.py 0750 system-config-netboot.noarch: E: script-without-shebang /usr/share/system-config-netboot/netboot_gtk.py system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/system-config-netboot.py 0750 system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/system-config-netboot.py 0750 system-config-netboot.noarch: W: no-dependency-on usermode system-config-netboot.noarch: W: obsolete-not-provided redhat-config-netboot AND system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeos.py 0750 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeos.py 0750 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeboot.py 0750 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeboot.py 0750 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/firsttime.py 0644 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/updateDiskless 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/updateDiskless 0700 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/syncfiles 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/syncfiles 0700 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless/diskless.init 0644 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/disklessrc 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/disklessrc 0700 system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/mkdiskless 0700 system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/mkdiskless 0700 system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless.py 0644 system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/boot.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/expert.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/general.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/param.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/rescue.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/snake.msg system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/pxelinux.0 Suggestions:- 1) why some of above mentioned files are non-readable? you can make them readable. 2) For config files guidelines says http://fedoraproject.org/wiki/PackagingGuidelines#Configuration_files 3) Desktop files must be installed as per given http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage 4) Use following scriptlet for icon files https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
Ok, so it looks it needs more love, I'll take a deeper look to fix it. Sorry I didn't checked rpmlint, hoping package is in better condition...
Well I'm looking to rpmlint output now. > W: non-etc-or-var-file-marked-as-conffile I think it's fine - these files are config files which SHOULD NOT be replaced but are not located in /etc or /var.
(In reply to comment #7) > Well I'm looking to rpmlint output now. > > > W: non-etc-or-var-file-marked-as-conffile > > I think it's fine - these files are config files which SHOULD NOT be replaced > but are not located in /etc or /var. thats ok then. Do you got new package to complete review with fixes other issues?
(In reply to comment #8) > > thats ok then. Do you got new package to complete review with fixes other > issues? I have to prepare new minor upstream release to fix rpmlint warnings, so I hope packages will be ready Monday.
ping?
Sorry, it takes so long but now it's already built for rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=1088883
from build.log you can see warning: File listed twice: /tftpboot/linux-install/msgs warning: File listed twice: /tftpboot/linux-install/msgs/boot.msg warning: File listed twice: /tftpboot/linux-install/msgs/expert.msg warning: File listed twice: /tftpboot/linux-install/msgs/general.msg warning: File listed twice: /tftpboot/linux-install/msgs/param.msg warning: File listed twice: /tftpboot/linux-install/msgs/rescue.msg warning: File listed twice: /tftpboot/linux-install/msgs/snake.msg warning: File listed twice: /tftpboot/linux-install/pxelinux.0 warning: File listed twice: /tftpboot/linux-install/pxelinux.cfg Please see http://fedoraproject.org/wiki/PackagingGuidelines#Duplicate_Files ===> You want to have in %files of -cmd as only %config(noreplace) /tftpboot/linux-install/ This will make all files under this /tftpboot/linux-install/ directory as configuration files.
2) also, gtk-update-icon-cache scriptlet should be %post touch --no-create %{_datadir}/icons/hicolor if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi %postun touch --no-create %{_datadir}/icons/hicolor if [ -x %{_bindir}/gtk-update-icon-cache ] ; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi 3) Buildroot should be one of values from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
Added Parag as 'Assignee' because the review is in progress.
Updated package in Rawhide.
Thanks for your work. APPROVED.
(In reply to comment #16) > Thanks for your work. > APPROVED. Ok, thank you for your great review!
package is in rawhide. Closing this review now.