Bug 226463 - Merge Review: system-config-netboot
Merge Review: system-config-netboot
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:06 EST by Nobody's working on this, feel free to take it
Modified: 2009-09-21 16:36 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-05 00:37:18 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)
patch to silent rpmlint output on srpm (2.02 KB, patch)
2008-12-22 03:23 EST, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:06:07 EST
Fedora Merge Review: system-config-netboot

http://cvs.fedora.redhat.com/viewcvs/devel/system-config-netboot/
Initial Owner: fleite@redhat.com
Comment 1 Fabian Affolter 2008-12-15 06:14:05 EST
Just some comments on this spec file

- Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
- Use parallel make (make %{?_smp_mflags})
- Is there a reason that %makeinstall is used? 
  https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
Comment 2 Parag AN(पराग) 2008-12-19 02:37:08 EST
cc'ing current owner of this package jreznik@redhat.com
Comment 3 Jaroslav Reznik 2008-12-19 06:43:59 EST
Thank you for cc'ing me here, issues are fixed now in devel. I'm only not sure if we really need smp_flags - it's noarch package.
Comment 4 Parag AN(पराग) 2008-12-22 03:23:17 EST
Created attachment 327623 [details]
patch to silent rpmlint output on srpm
Comment 5 Parag AN(पराग) 2008-12-22 03:29:50 EST
Still there are rpmlint output not silent on rpms
system-config-netboot.noarch: E: non-executable-script /usr/share/system-config-netboot/pxeosdialog.py 0644
system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/netboot_gtk.py 0750
system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/netboot_gtk.py 0750
system-config-netboot.noarch: E: script-without-shebang /usr/share/system-config-netboot/netboot_gtk.py
system-config-netboot.noarch: E: non-readable /usr/share/system-config-netboot/system-config-netboot.py 0750
system-config-netboot.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/system-config-netboot.py 0750
system-config-netboot.noarch: W: no-dependency-on usermode
system-config-netboot.noarch: W: obsolete-not-provided redhat-config-netboot

AND
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeos.py 0750
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeos.py 0750
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/pxeboot.py 0750
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/pxeboot.py 0750
system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/firsttime.py 0644
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/updateDiskless 0700
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/updateDiskless 0700
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/syncfiles 0700
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/syncfiles 0700
system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless/diskless.init 0644
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/disklessrc 0700
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/disklessrc 0700
system-config-netboot-cmd.noarch: E: non-readable /usr/share/system-config-netboot/diskless/mkdiskless 0700
system-config-netboot-cmd.noarch: E: non-standard-executable-perm /usr/share/system-config-netboot/diskless/mkdiskless 0700
system-config-netboot-cmd.noarch: E: non-executable-script /usr/share/system-config-netboot/diskless.py 0644
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/boot.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/expert.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/general.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/param.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/rescue.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/msgs/snake.msg
system-config-netboot-cmd.noarch: W: non-etc-or-var-file-marked-as-conffile /tftpboot/linux-install/pxelinux.0


Suggestions:-
1) why some of above mentioned files are non-readable? you can make them readable.
2) For config files guidelines says http://fedoraproject.org/wiki/PackagingGuidelines#Configuration_files
3) Desktop files must be installed as per given
http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
4) Use following scriptlet for icon files
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
Comment 6 Jaroslav Reznik 2008-12-22 15:04:54 EST
Ok, so it looks it needs more love, I'll take a deeper look to fix it. Sorry I didn't checked rpmlint, hoping package is in better condition...
Comment 7 Jaroslav Reznik 2009-01-05 10:41:41 EST
Well I'm looking to rpmlint output now.

> W: non-etc-or-var-file-marked-as-conffile

I think it's fine - these files are config files which SHOULD NOT be replaced but are not located in /etc or /var.
Comment 8 Parag AN(पराग) 2009-01-08 23:39:16 EST
(In reply to comment #7)
> Well I'm looking to rpmlint output now.
> 
> > W: non-etc-or-var-file-marked-as-conffile
> 
> I think it's fine - these files are config files which SHOULD NOT be replaced
> but are not located in /etc or /var.

thats ok then. Do you got new package to complete review with fixes other issues?
Comment 9 Jaroslav Reznik 2009-01-09 11:34:56 EST
(In reply to comment #8)
> 
> thats ok then. Do you got new package to complete review with fixes other
> issues?

I have to prepare new minor upstream release to fix rpmlint warnings, so I hope packages will be ready Monday.
Comment 10 Parag AN(पराग) 2009-01-19 23:34:24 EST
ping?
Comment 11 Jaroslav Reznik 2009-01-28 10:41:20 EST
Sorry, it takes so long but now it's already built for rawhide - http://koji.fedoraproject.org/koji/taskinfo?taskID=1088883
Comment 12 Parag AN(पराग) 2009-01-29 04:27:28 EST
from build.log you can see
warning: File listed twice: /tftpboot/linux-install/msgs
warning: File listed twice: /tftpboot/linux-install/msgs/boot.msg
warning: File listed twice: /tftpboot/linux-install/msgs/expert.msg
warning: File listed twice: /tftpboot/linux-install/msgs/general.msg
warning: File listed twice: /tftpboot/linux-install/msgs/param.msg
warning: File listed twice: /tftpboot/linux-install/msgs/rescue.msg
warning: File listed twice: /tftpboot/linux-install/msgs/snake.msg
warning: File listed twice: /tftpboot/linux-install/pxelinux.0
warning: File listed twice: /tftpboot/linux-install/pxelinux.cfg

Please see http://fedoraproject.org/wiki/PackagingGuidelines#Duplicate_Files

===> You want to have in %files of -cmd as only
%config(noreplace) /tftpboot/linux-install/

This will make all files under this /tftpboot/linux-install/ directory as configuration files.
Comment 13 Parag AN(पराग) 2009-01-29 04:35:41 EST
2) also, gtk-update-icon-cache scriptlet should be 
%post
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
  %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

%postun
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
  %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi

3) Buildroot should be one of values from http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag
Comment 14 Fabian Affolter 2009-01-29 08:49:54 EST
Added Parag as 'Assignee' because the review is in progress.
Comment 15 Jaroslav Reznik 2009-02-03 09:24:24 EST
Updated package in Rawhide.
Comment 16 Parag AN(पराग) 2009-02-04 01:45:58 EST
Thanks for your work.
APPROVED.
Comment 17 Jaroslav Reznik 2009-02-04 03:34:26 EST
(In reply to comment #16)
> Thanks for your work.
> APPROVED.

Ok, 
thank you for your great review!
Comment 18 Parag AN(पराग) 2009-02-05 00:37:18 EST
package is in rawhide. Closing this review now.

Note You need to log in before you can comment on or make changes to this bug.