Bug 2264675 - Review Request: rust-sequoia-keystore-softkeys - Soft key (in-memory key) backend for Sequoia's key store
Summary: Review Request: rust-sequoia-keystore-softkeys - Soft key (in-memory key) bac...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sequoia-keys...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-17 18:53 UTC by Fabio Valentini
Modified: 2024-02-29 11:23 UTC (History)
2 users (show)

Fixed In Version: rust-sequoia-keystore-softkeys-0.2.0-1.fc41
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-29 11:23:54 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7030850 to 7049475 (818 bytes, patch)
2024-02-22 14:09 UTC, Fedora Review Service
no flags Details | Diff

Description Fabio Valentini 2024-02-17 18:53:40 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-sequoia-keystore-softkeys.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-sequoia-keystore-softkeys-0.1.0-1.fc39.src.rpm

Description:
A soft key (in-memory key) backend for Sequoia's key store.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-02-17 18:53:43 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=113654543

Comment 2 Fedora Review Service 2024-02-18 09:00:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7030850
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264675-rust-sequoia-keystore-softkeys/fedora-rawhide-x86_64/07030850-rust-sequoia-keystore-softkeys/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-02-22 14:09:26 UTC
Created attachment 2018162 [details]
The .spec file difference from Copr build 7030850 to 7049475

Comment 5 Fedora Review Service 2024-02-22 14:09:29 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7049475
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264675-rust-sequoia-keystore-softkeys/fedora-rawhide-x86_64/07049475-rust-sequoia-keystore-softkeys/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Michel Lind 2024-02-22 23:24:50 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (LGPL-2.0-or-later) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2024-02-29 10:54:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sequoia-keystore-softkeys

Comment 8 Fabio Valentini 2024-02-29 11:23:54 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6fe4836a61


Note You need to log in before you can comment on or make changes to this bug.