(!!) MUST: rpmlint output:
**** Review message:
E: tcpdump tag-not-utf8 %changelog
E: tcpdump non-utf8-spec-file tcpdump.spec
   - The spec file must use UTF-8 encoding

W: tcpdump macro-in-%changelog post
   - Line: 316 - disable /etc/init.d requirement and fix %post scripts in arpwatch
     Should be "%%post"

W: tcpdump macro-in-%changelog attr
   - Line: 493 - uses a buildroot and %attr
     Should be "%%attr"

********************

Thanks, should be fixed in tcpdump-3.9.5-3.fc7.

Just done a full check on tcpdump-14:3.9.8-6
The following aesthetic change will make rpmlint happier. Otherwise the package is just fine, no need to keep it on the list of merge reviews


< iconv -f iso-8859-1 -t utf-8 CREDITS > CREDITS.UTF-8
< touch -r CREDITS CREDITS.UTF-8
< mv CREDITS.UTF-8 CREDITS

I can do the update in CVS myself if you want.

APPROVED

Thanks for the review. I'll add the conversion in the next update.

make sure to close this bug when you are done, please.