Red Hat Bugzilla – Bug 226482
Merge Review: tcp_wrappers
Last modified: 2016-11-28 04:42:04 EST
Fedora Merge Review: tcp_wrappers
Initial Owner: email@example.com
Review against tcp_wrappers-7.6-43
The following itens should be fixed/improved:
* the post/postun scripts belong to the -libs subpackage
* remove the end dots in the summary lines (rpmlint)
* the buildroot is not the canonical one
* the files timestamps should be preserved (replace "cp" by "install -p mxxx")
* replace %defattr(-,root,root) by %defattr(-,root,root,-)
* Why is tcpd installed with a 711 mask?
Reassigning this bug to the component owner.
Manually reassigning to Tomas Janousek.
Package Change Request
Package Name: tcp_wrappers
New Branches: F-8
Thanks for your review and sorry for the delay.
I incorporated your suggestions:
Please note that at least the License field has changed since the time you
The tcpd binary was 711 since/because of this changelog entry:
* Tue May 16 2000 Chris Evans <firstname.lastname@example.org>
- Make tcpd mode -rwx--x--x as a security hardening measure
I changed it to 755, since even suid binaries are no longer non-readable.
Adding Tomas Janousek on Cc because of being the current maintainer.
* tcp_wrappers.src: W: mixed-use-of-spaces-and-tabs (spaces: line 249, tab: line 37)
* tcp_wrappers.x86_64: E: obsolete-on-name
I wonder why tcp_wrappers obsoletes itself, for clean update path is >N-V-R enough when the name is the same, right?
* tcp_wrappers-devel.x86_64: W: summary-not-capitalized tcp_wrappers development libraries and headers
* tcp_wrappers-libs.x86_64: W: summary-not-capitalized tcp_wrappers libraries
tcp_wrappers-libs... -> Tcp_wrappers-libs...
* tcp_wrappers-devel.x86_64: W: obsolete-not-provided tcp_wrappers
* tcp_wrappers-libs.x86_64: W: obsolete-not-provided tcp_wrappers
preferably dump the whote "Obsoletes" and we are done.
The rest looks good to me.
jchadima is current tcp_wrappers owner
All requested actios done.
Will get back to this, when I find more time.
Mass reassigning all merge reviews to their component. For more details, see this FESCO ticket:
If you don't know what merge reviews are about, please see:
How to handle this bug is left to the discretion of the package maintainer.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.
(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)
More information and reason for this action is here:
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora 'version'
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 23 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
I just updated minor problems found from Fedora Review and pointed out in the above comments:
* Remove BuildRoot
* add smp flags
* remove %clean
* fully versioned requires
The update to rawhide is coming. The older releases are not needed.