Bug 226491 - Merge Review: time
Merge Review: time
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Florian La Roche
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:10 EST by Nobody's working on this, feel free to take it
Modified: 2008-01-11 16:11 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-11 16:11:23 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ruben: fedora‑review-


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:10:31 EST
Fedora Merge Review: time

http://cvs.fedora.redhat.com/viewcvs/devel/time/
Initial Owner: laroche@redhat.com
Comment 1 Ruben Kerkhof 2007-02-05 16:41:06 EST
Hi Florian,

Here's my review for time 1.7 release 28:
* RPM name is OK
* Source time-1.7.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
  (wiki: PackagingGuidelines#RelocatablePackages)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)


Notes:
* Use Requires(post) and Requires(preun) instead of Prereq
* Is "echo "ac_cv_func_wait3=\${ac_cv_func_wait3='yes'}" >> config.cache" still needed?
  the configure script detects wait3 without it as well (at least, on FC-6)


Rpmlint is not silent:

Source RPM:
W: time summary-ended-with-dot A GNU utility for monitoring a program's use of system resources.
W: time no-url-tag
W: time redundant-prefix-tag
W: time prereq-use /sbin/install-info
W: time mixed-use-of-spaces-and-tabs (spaces: line 39, tab: line 34)

rpmlint of time:
W: time summary-ended-with-dot A GNU utility for monitoring a program's use of system resources.
W: time no-version-in-last-changelog
W: time no-url-tag
Comment 2 Florian La Roche 2008-01-11 16:11:23 EST
Seems current rpmlint is ok with the rpm package, so I am closing this bz.

Thanks a lot for the review,

Florian La Roche

Note You need to log in before you can comment on or make changes to this bug.