Red Hat Bugzilla – Bug 226500
Merge Review: totem
Last modified: 2010-11-11 01:45:44 EST
Fedora Merge Review: totem http://cvs.fedora.redhat.com/viewcvs/devel/totem/ Initial Owner: alexl@redhat.com
New Initial Owner: bnocera@redhat.com
Created attachment 449858 [details] spec cleanup Please review the changes, commit this or allow to commit and build this package.
Following are the changes proposed in above patch 1) Generally we used to have dependent packages already built in repo so I guess no need of versioned BuildRequires: and also Requires: See,https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires If this package needs versioned BR: and R: then please add comment in spec file 2) Guidelines shows no need to use versioned scriptlet Requires: needed. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf 3)Guidelines shows no need of following in spec now as per https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage Requires(post): desktop-file-utils Requires(postun): desktop-file-utils 4) Removal of Obsoletes and Provides is recommended after 2 releases See http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F 5) Guidelines suggests to keep timestamps of upstream installed files. So please use make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps 6) Guidelines suggests package built above F-13 do not need %clean See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean 7) Updated scriptlets used as per guidelines suggested a) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scrollkeeper says "In all current Fedora, rarian has replaced scrollkeeper. There is no scriptlet needed for rarian" b) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database c) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache d) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf 8) Guidelines recommends defattr usage as %defattr(-, root, root,-) See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
ping hadess
hadess, To avoid delays in completing this merge-review process, If I will not get any reply by next Monday, I will commit this patch and build new package in rawhide.
Will build this tommorrow
Strange patch applied successfully but got build error.
deps are really broken in rawhide now. looks some success can be done with 2.32 totem tarball.
Nice to see totem build. APPROVED.