Bug 226500 - Merge Review: totem
Merge Review: totem
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-31 16:11 EST by Nobody's working on this, feel free to take it
Modified: 2010-11-11 01:45 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-11-11 01:45:44 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+

Attachments (Terms of Use)
spec cleanup (7.83 KB, patch)
2010-09-27 05:59 EDT, Parag AN(पराग)
no flags Details | Diff

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:11:58 EST
Fedora Merge Review: totem

Initial Owner: alexl@redhat.com
Comment 1 Alexander Larsson 2007-02-08 06:12:35 EST
New Initial Owner: bnocera@redhat.com
Comment 2 Parag AN(पराग) 2010-09-27 05:59:10 EDT
Created attachment 449858 [details]
spec cleanup

Please review the changes, commit this or allow to commit and build this package.
Comment 3 Parag AN(पराग) 2010-09-27 06:16:11 EDT
Following are the changes proposed in above patch
1) Generally we used to have dependent packages already built in repo so I guess no need of versioned BuildRequires: and also Requires:


If this package needs versioned BR: and R: then please add comment in spec file

2) Guidelines shows no need to use versioned scriptlet Requires: needed. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

3)Guidelines shows no need of following in spec now as per https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

4) Removal of Obsoletes and Provides is recommended after 2 releases
See http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F

5) Guidelines suggests to keep timestamps of upstream installed files. So please use 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

See https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

6) Guidelines suggests package built above F-13 do not need %clean

See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

7) Updated scriptlets used as per guidelines suggested
 a) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Scrollkeeper
says "In all current Fedora, rarian has replaced scrollkeeper. There is no scriptlet needed for rarian"
 b) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
 c) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
 d) https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf

8) Guidelines recommends defattr usage as 
%defattr(-, root, root,-)
See https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
Comment 4 Parag AN(पराग) 2010-09-27 21:25:26 EDT
ping hadess
Comment 5 Parag AN(पराग) 2010-09-28 23:30:05 EDT
    To avoid delays in completing this merge-review process, If I will not get any reply by next Monday, I will commit this patch and build new package in rawhide.
Comment 6 Parag AN(पराग) 2010-10-04 05:10:04 EDT
Will build this tommorrow
Comment 7 Parag AN(पराग) 2010-10-05 01:12:54 EDT
Strange patch applied successfully but got build error.
Comment 8 Parag AN(पराग) 2010-10-07 06:15:46 EDT
deps are really broken in rawhide now. looks some success can be done with 2.32 totem tarball.
Comment 9 Parag AN(पराग) 2010-11-11 01:45:44 EST
Nice to see totem build.


Note You need to log in before you can comment on or make changes to this bug.