Fedora Merge Review: traceroute http://cvs.fedora.redhat.com/viewcvs/devel/traceroute/ Initial Owner: mbacovsk
Hmmm, nothing prevents me to review this one... ;) All seems OK, except IMHO the dist tag (.fc7) should not be included into changelog section. Another packages seem to not include it... (or maybe I'm wrong?)
What a surprise you took this package for review :) Can be proud father objective enough? :) As for dist tags in changelog, is there any rule forbiding that? I find it usefull to keep track when rawhide was splited to new branch. I also have it in other packages which got fedora-review +.
Personally I absolutely dislike dist tag in changelog, but it should be nothing which prevents from approving as I know of no guideline forbidding that. Dmitry, are you doing any formal review?
> other packages which got fedora-review +. [snip] > no guideline forbidding that OK, let's it be. > are you doing any formal review? Yep. The package's .spec was derived from the tarball's .spec, which was written by me using all FE guidelines :) . But I've re-checked things again. Must/SHould items: OK rmplint: OK APPROVED.
Reviews should be assigned to reviewer so just reassigning...