Description of problem: In the most recent build of visidata [1], the shebang is modified as such: + /usr/lib/rpm/redhat/brp-mangle-shebangs mangling shebang in /usr/bin/vd2to3.vdx from /usr/bin/env -S vd -p to #!/usr/bin/-S vd -p This obviously results in a broken command-line, and a dependency on a non-existent /usr/bin/-S (aka bug 2264962). I can fix this easily, of course, but the packaging guidelines do say "Various checks are also applied to verify that the shebang lines are valid, and the build process can fail as a result of these." but this appears to have slipped through. Version-Release number of selected component (if applicable): redhat-rpm-config-284-1.fc41.noarch Additional info: [1] https://koji.fedoraproject.org/koji/buildinfo?buildID=2405440
This sounds like an obvious bug.
The code: # Replace "special" env shebang: # /whatsoever/env /whatever/foo → /whatever/foo shebang=$(echo "$shebang" | sed -r -e 's@^(.+)/env /(.+)$@/\2@') # /whatsoever/env foo → /whatsoever/foo shebang=$(echo "$shebang" | sed -r -e 's@^(.+/)env (.+)$@\1\2@') Current problematic behavior: $ echo '/usr/bin/env -S /usr/bin/vd' | sed -r -e 's@^(.+)/env /(.+)$@/\2@' /usr/bin/env -S /usr/bin/vd $ echo '/usr/bin/env -S vd' | sed -r -e 's@^(.+/)env (.+)$@\1\2@' /usr/bin/-S vd Proposed fix: $ echo '/usr/bin/env -S /usr/bin/vd' | sed -r -e 's@^(.+)/env( -[^ ]+)* /(.+)$@/\3@' /usr/bin/vd $ echo '/usr/bin/env -S vd' | sed -r -e 's@^(.+/)env( -[^ ]+)* (.+)$@\1\3@' /usr/bin/vd Works even without env flags: $ echo '/usr/bin/env /usr/bin/vd' | sed -r -e 's@^(.+)/env( -[^ ]+)* /(.+)$@/\3@' /usr/bin/vd $ echo '/usr/bin/env vd' | sed -r -e 's@^(.+/)env( -[^ ]+)* (.+)$@\1\3@' /usr/bin/vd Or with multiple env flags: $ echo '/usr/bin/env -X -y /usr/bin/vd' | sed -r -e 's@^(.+)/env( -[^ ]+)* /(.+)$@/\3@' /usr/bin/vd $ echo '/usr/bin/env -X -yabc -Z vd' | sed -r -e 's@^(.+/)env( -[^ ]+)* (.+)$@\1\3@' /usr/bin/vd
https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/285
FEDORA-2024-edbda6f051 (redhat-rpm-config-285-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-edbda6f051
FEDORA-2024-edbda6f051 (redhat-rpm-config-285-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
Reopening, this affects all Fedoras (as well as RHEL).
FEDORA-2024-19fc022649 (redhat-rpm-config-285-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-19fc022649
Backports further down: https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/288 https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/289
RHEL report: https://issues.redhat.com/browse/RHEL-26961
FEDORA-2024-19fc022649 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-19fc022649` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-19fc022649 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
I nominate this a s a freeze exception. For the following reasons: - it blocks bz2264975 which is an installation failure -- we want that fixed ASAP - due to the nature of this package, it is unlikely to receive much testing unless pushed to stable and used in Koji
FEDORA-2024-f83e42dd48 (redhat-rpm-config-266-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f83e42dd48
FEDORA-2024-f83e42dd48 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f83e42dd48` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f83e42dd48 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1487 , marking accepted FE.
FEDORA-2024-19fc022649 (redhat-rpm-config-285-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b45fa71757 (redhat-rpm-config-257-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b45fa71757
FEDORA-2024-b45fa71757 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b45fa71757` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b45fa71757 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-f83e42dd48 (redhat-rpm-config-266-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b45fa71757 (redhat-rpm-config-257-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.