Red Hat Bugzilla – Bug 226504
Merge Review: tsclient
Last modified: 2012-06-15 12:26:45 EDT
Fedora Merge Review: tsclient
Initial Owner: firstname.lastname@example.org
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
FIX - Spec has consistant macro usage.
- Do not use %makeinstall macro
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - Package needs ExcludeArch
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package is relocatable and has a reason to be.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
FIX - Package is a GUI app and has a .desktop file
- Vendor should be set to fedora instead of tsclient
- remove the " --add-category Utility " entry
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
FIX - No rpmlint output.
tsclient.src: W: mixed-use-of-spaces-and-tabs (spaces: line 50,
tab: line 53)
tsclient.i386: W: incoherent-version-in-changelog 0.150.5
tsclient.i386: E: incorrect-locale-el
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo
=; rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk
and anything provided by glibc.)
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have subpackages require base package with fully versioned depend.
OK - Should have dist tag
OK - Should package latest version
FIX - check for outstanding bugs on package. (For core merge reviews)
242315 - remove the Utility category (see above)
1. Do not use %makeinstall macro
2. Fix vendor in desktop file, should be fedora
3. Fix bug 242315
4. rpmlint not quiet
rpm: Changelog should use - instead of . to denote release
Need to notify upstream that the Greek local has changed from el
Adding davidz to this ticket
I am doing this b/c he is listed as the owner in the pkgdb
1. The current tsclient spec file doesn't use %makeinstall
2. Adding a vendor prefix is a bad idea, it has the potential to break code that
assumes that it can refer to the tsclient desktop file by the id 'tsclient'.
We are moving away from blindly forcing a vendor prefix.
4. I'm not going to patch old ChangeLog entries. tsclient 2.0.1 doesn't ship Greek translations, el or gr.
Old bug - long since merged so closing.
(In reply to comment #4)
> Old bug - long since merged so closing.
Yes, it's old, but I can't see that the merge review was finished.
Errr, okay. So are you going to complete the review?
Not sure I can see the value in keeping it open however as all issues raised were addressed.
Happy for this to be re-opened if someone is going to do the paperwork to get it completed but this appears to be rather bureaucratic.
I'm closing this bug since tsclient was removed due to dead upstream and at least two superior alternatives (remmina and gnome-rdp)
This bug just popped out when I searched for packages under review but looks like this package was retired already.
Dropping the flag fedora-review?