Bug 2265134 - Review Request: rust-liboci-cli - Parse command line arguments for OCI container runtimes
Summary: Review Request: rust-liboci-cli - Parse command line arguments for OCI contai...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/liboci-cli
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-20 15:53 UTC by Alberto Faria
Modified: 2024-02-27 13:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-27 13:40:34 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2024-02-20 16:05:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7039423
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265134-rust-liboci-cli/fedora-rawhide-x86_64/07039423-rust-liboci-cli/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Richard W.M. Jones 2024-02-20 16:56:57 UTC
You might want to ask Fabio Valentini as he is the rust maintainer, or better
still post on Fedora-devel-list offering a review swap.

I compared the spec file to rust-cc
(https://src.fedoraproject.org/rpms/rust-cc/blob/rawhide/f/rust-cc.spec)
and it seems broadly sensible.  Looks like it was generated by rust2rpm
and not modified.

Comment 3 Michel Lind 2024-02-23 17:27:48 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- [BINARY ONLY] licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fedora Admin user for bugzilla script actions 2024-02-27 13:11:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-liboci-cli

Comment 5 Fedora Update System 2024-02-27 13:35:36 UTC
FEDORA-2024-a2363af4c1 (rust-liboci-cli-0.3.2-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a2363af4c1

Comment 6 Fedora Update System 2024-02-27 13:39:41 UTC
FEDORA-2024-2e762b1260 (rust-liboci-cli-0.3.2-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2e762b1260

Comment 7 Fedora Update System 2024-02-27 13:40:34 UTC
FEDORA-2024-a2363af4c1 (rust-liboci-cli-0.3.2-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-02-27 13:43:34 UTC
FEDORA-2024-2e762b1260 (rust-liboci-cli-0.3.2-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.