Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2265281 - Flood of dynflow related messages like "do not serialize to JSON safely" during repo sync after upgrading to Satellite 6.14.2
Summary: Flood of dynflow related messages like "do not serialize to JSON safely" duri...
Keywords:
Status: ON_QA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Tasks Plugin
Version: 6.14.0
Hardware: All
OS: All
medium
medium
Target Milestone: stream
Assignee: Adam Ruzicka
QA Contact: Satellite QE Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-21 09:19 UTC by Sayan Das
Modified: 2024-05-07 06:14 UTC (History)
6 users (show)

Fixed In Version: rubygem-dynflow-1.8.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 37190 0 Normal Assigned Suppress serialization-related warnings coming from sidekiq 2024-02-21 09:39:55 UTC
Github Dynflow dynflow issues 436 0 None open "do not serialize to JSON safely" warnings when used with sidekiq 6.5 2024-02-21 09:19:27 UTC
Red Hat Issue Tracker SAT-23505 0 None None None 2024-02-22 00:25:35 UTC

Description Sayan Das 2024-02-21 09:19:28 UTC 
Description of problem:

In Satellite 6.14.2 or later, Whenever we perform some repo sync tasks, with every single poll attempt on the tasks, a lot of dynflow-related warnings are bring printed and they are flooding the logs.

Consider a scenario where some daily or weekly sync plans are configured, the syslog will be completely flooded with those dynflow warning messages. 


Version-Release number of selected component (if applicable):

Satellite 6.14.2 or later
Sidekiq 6.5 or later


How reproducible:

Always


Steps to Reproduce:
1. Install Satellite 6.14.2 
2. Import a manifest with one valid RHEL sub
3. Enable couple of repos and sync them
4. Check /var/log/messages file

Actual results:

Lots of dynflow warnings printed in the logs e.g. 

Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: 2024-02-21T09:14:06.322Z pid=18149 tid=gq1h WARN: Job arguments to Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: 2024-02-21T09:14:06.322Z pid=18149 tid=gq1h WARN: Job arguments to Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: 2024-02-21T09:14:06.375Z pid=18256 tid=bdjg class=Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork jid=38083cc9eff10ddbad79dc3a WARN: Job arguments to Dynflow::Executors::Sidekiq::OrchestratorJobs::WorkerDone do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: 2024-02-21T09:14:06.394Z pid=18256 tid=bdtc class=Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork jid=f65b85d85d3c50c390ce14e3 WARN: Job arguments to Dynflow::Executors::Sidekiq::OrchestratorJobs::WorkerDone do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: 2024-02-21T09:14:06.395Z pid=18149 tid=gq1h WARN: Job arguments to Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@orchestrator[18149]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: 2024-02-21T09:14:06.673Z pid=18256 tid=bdv8 class=Dynflow::Executors::Sidekiq::WorkerJobs::PerformWork jid=048a864113a8000f63dbf5a0 WARN: Job arguments to Dynflow::Executors::Sidekiq::OrchestratorJobs::WorkerDone do not serialize to JSON safely. This will raise an error in
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
Feb 21 14:44:06 satellite614 dynflow-sidekiq@worker-1[18256]: by calling `Sidekiq.strict_args!` during Sidekiq initialization.


Expected results:

No such warnings or error messages or an option to suppress them


Additional info:

Related github issue https://github.com/Dynflow/dynflow/issues/436
Comment 1 Sayan Das 2024-02-21 09:20:16 UTC 
No such logs in Satellite 6.14.1 or before as they come with sidekiq < 6.5 i.e. 6.3
Comment 2 Adam Ruzicka 2024-02-21 09:38:37 UTC 
We are aware of the changes that are planned for Sidekiq 7 and which cause this warning to be emitted. The need to adjust to it is tracked as SAT-13787[1]. In here I'd opt for just suppressing the warnings, which should be a small change that could be cherrypicked all the way back to 6.14.z

[1] - https://issues.redhat.com/browse/SAT-13787
Note You need to log in before you can comment on or make changes to this bug.