Bug 226530 - Merge Review: vlock
Merge Review: vlock
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Karel Zak
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:15 EST by Nobody's working on this, feel free to take it
Modified: 2010-02-21 06:35 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-02-21 06:35:51 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
ruben: fedora‑review-


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:15:52 EST
Fedora Merge Review: vlock

http://cvs.fedora.redhat.com/viewcvs/devel/vlock/
Initial Owner: kzak@redhat.com
Comment 1 Ruben Kerkhof 2007-02-05 16:14:38 EST
Review for release 23:
* RPM name is OK
* Source vlock-1.3.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
  Please add COPYING from the source to %doc

Notes:
* Please consider using {?dist} in the Release tag
* Preserve timestamps when installing files

Rpmlint is not silent:

Source RPM:
W: vlock summary-ended-with-dot A program which locks one or more virtual consoles.
W: vlock no-url-tag

rpmlint of vlock:
W: vlock summary-ended-with-dot A program which locks one or more virtual consoles.
W: vlock no-url-tag
W: vlock conffile-without-noreplace-flag /etc/pam.d/vlock
Comment 2 Karel Zak 2007-02-07 16:47:02 EST
Thanks for your enthusiasm. I'm going to fix/improve the package in next week(s).
Comment 3 Karel Zak 2007-03-01 10:21:11 EST
Fixed. Update to vlock-1.3-24.fc7
Comment 4 Karel Zak 2007-03-01 10:48:16 EST
Note, I forgot install -p, fixed in the -25 release.
Comment 5 Ruben Kerkhof 2010-02-21 06:35:51 EST
Wow, forgot about this one.
Approved.

Note You need to log in before you can comment on or make changes to this bug.