Fedora Merge Review: vsftpd http://cvs.fedora.redhat.com/viewcvs/devel/vsftpd/ Initial Owner: mbarabas
Good: + License GPL + Follows naming guidelines + URL to source + %clean section + use of %doc macro Fix these and it's approved: - Use %{_var}, %{_sysconfdir}, and %{_sbindir} macros for %files and %install - Change Prereq to Requires. Also use Requires (post) and Requires (preun) style for chkconfig and service requirements. - use preferred BuildRoot of %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Also drop this stuff, unneeded: - "[ "$RPM_BUILD_ROOT" != "/" ] && " in %clean - Requires: openssl, pam, libcap - usermod requirement, not used (commented out).