Bug 226533 - Merge Review: vsftpd
Merge Review: vsftpd
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Maros Barabas
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:16 EST by Nobody's working on this, feel free to take it
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-04-04 09:14:28 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jpmahowald: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:16:08 EST
Fedora Merge Review: vsftpd

http://cvs.fedora.redhat.com/viewcvs/devel/vsftpd/
Initial Owner: mbarabas@redhat.com
Comment 1 John Mahowald 2007-02-03 11:33:15 EST
Good:
+ License GPL
+ Follows naming guidelines
+ URL to source
+ %clean section
+ use of %doc macro

Fix these and it's approved:
- Use %{_var}, %{_sysconfdir}, and %{_sbindir} macros for %files and %install
- Change Prereq to Requires. Also use Requires (post) and Requires (preun) style
for chkconfig and service requirements.
- use preferred BuildRoot of
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Also drop this stuff, unneeded:
- "[ "$RPM_BUILD_ROOT" != "/" ] && " in %clean
- Requires: openssl, pam, libcap
- usermod requirement, not used (commented out).

Note You need to log in before you can comment on or make changes to this bug.