Spec URL: https://principis.fedorapeople.org/goarrange.spec SRPM URL: https://principis.fedorapeople.org/goarrange-1.0.0-1.fc39.src.rpm Description: Automatic arrangement of Go source code Fedora Account System Username: principis
Copr build: https://copr.fedorainfracloud.org/coprs/build/7046001 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265338-goarrange/fedora-rawhide-x86_64/07046001-goarrange/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you update go2rpm to 1.11.0? There a couple of changes in the template. > %global goname goarrange This is not required anymore, newer go2rpm does it correctly. > %gopkginstall > (...) > %gopkgfiles These are not required if you don't need the `golang-github-jdeflander-goarrange-devel` package. Remove these to create only the binary package.
Thanks, recreated the spec with go2rpm 1.11.0. Spec URL: https://principis.fedorapeople.org/goarrange.spec SRPM URL: https://principis.fedorapeople.org/goarrange-1.0.0-1.fc39.src.rpm
Created attachment 2020993 [details] The .spec file difference from Copr build 7046001 to 7131963
Copr build: https://copr.fedorainfracloud.org/coprs/build/7131963 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265338-goarrange/fedora-rawhide-x86_64/07131963-goarrange/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Removed glob under shared directory Spec URL: https://principis.fedorapeople.org/goarrange.spec SRPM URL: https://principis.fedorapeople.org/goarrange-1.0.0-1.fc39.src.rpm
Created attachment 2021045 [details] The .spec file difference from Copr build 7131963 to 7132078
Copr build: https://copr.fedorainfracloud.org/coprs/build/7132078 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265338-goarrange/fedora-rawhide-x86_64/07132078-goarrange/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [x] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
The Pagure repository was created at https://src.fedoraproject.org/rpms/goarrange
Thank you for the review!
FEDORA-2024-51a86268c6 (goarrange-1.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-51a86268c6
FEDORA-2024-51a86268c6 (goarrange-1.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-89d69f6080 (goarrange-1.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-89d69f6080
FEDORA-2024-fc83f16f2d (goarrange-1.0.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-fc83f16f2d
FEDORA-2024-fc83f16f2d has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fc83f16f2d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fc83f16f2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-89d69f6080 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-89d69f6080 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-89d69f6080 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-89d69f6080 (goarrange-1.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-fc83f16f2d (goarrange-1.0.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.