Bug 226540 - Merge Review: wireless-tools
Merge Review: wireless-tools
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Kevin Fenzi
Fedora Package Reviews List
Depends On:
Blocks: F9MergeReviewTarget
  Show dependency treegraph
Reported: 2007-01-31 16:16 EST by Nobody's working on this, feel free to take it
Modified: 2014-12-15 08:16 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-12-21 20:07:07 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
kevin: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:16:43 EST
Fedora Merge Review: wireless-tools

Initial Owner: caillon@redhat.com
Comment 1 Kevin Fenzi 2007-12-20 22:21:47 EST
I'd be happy to review this package. 
Look for a full review in a bit. 
Comment 2 Kevin Fenzi 2007-12-20 22:48:57 EST
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL+)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
ae81659767bfe58d2c92a07eb453dc64  wireless_tools.29.pre22.tar.gz
ae81659767bfe58d2c92a07eb453dc64  wireless_tools.29.pre22.tar.gz.1
OK - Package needs ExcludeArch
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane.


OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
See below - Should package latest version
see below - check for outstanding bugs on package.


1. NON BLOCKER: might include the COPYING file as a doc?

2. NON BLOCKER: The 29 version is out... perhaps upgrade to that from this pre22

3. rpmlint says:

wireless-tools.src: E: non-utf8-spec-file
wireless-tools.src: E: tag-not-utf8 %changelog

Suggest: run iconv on the spec file to make it UTF8?

wireless-tools.src:42: W: setup-not-quiet

Suggest: add -q to setup line?

wireless-tools.x86_64: W: incoherent-version-in-changelog 1:29.0.2.pre22

Suggest: don't use dist tags in changelog entries.

wireless-tools-devel.x86_64: W: no-documentation

Suggest: ignore

wireless-tools-devel.x86_64: W: symlink-should-be-relative /usr/lib64/libiw.so

Suggest: should use a relative link? Perhaps this is something wrong in the
makefile patch?

4. 14 outstanding bugs, none of which seem to be at all packageing related.

All these are very minor issues... very clean package.
Would you be willing to make the minor changes for rpmlint?
Or if you like I would be happy to do so for you...
Comment 3 Christopher Aillon 2007-12-21 19:54:25 EST
> wireless-tools.x86_64: W: incoherent-version-in-changelog 1:29.0.2.pre22
> 1:29-0.2.pre22.fc9
> Suggest: don't use dist tags in changelog entries.

Looks like this is actually a typo... it's missing the "-" (to delimit the
version from the release).

Updated to 29 and fixed the rest of the issues I believe.
Comment 4 Kevin Fenzi 2007-12-21 20:07:07 EST
Excellent. Thanks for your quick attention here... 

Everything looks fixed, with the exception of COPYING included as a doc. 
Might be good to do that sometime, but not a blocker... 

This package is APPROVED. 
Comment 5 Mosaab Alzoubi 2014-12-14 10:07:09 EST
Package Change Request
Package Name: wireless-tools
New Branches: el5 el6 epel7
Owners: moceap dcbw
Comment 6 Gwyn Ciesla 2014-12-15 08:16:44 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.