Bug 2265716 - Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bounty & Hacking Tools
Summary: Review Request: golang-github-edoardottt-lit-bb-hack-tools - Little Bug Bount...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2265679
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-23 19:05 UTC by Tim Semeijn
Modified: 2024-03-08 00:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-03-08 00:17:27 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 7053551 to 7112353 (4.89 KB, patch)
2024-03-06 13:59 UTC, Fedora Review Service
no flags Details | Diff

Comment 1 Fedora Review Service 2024-02-23 19:08:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7053551
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265716-golang-github-edoardottt-lit-bb-hack-tools/fedora-rawhide-x86_64/07053551-golang-github-edoardottt-lit-bb-hack-tools/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2024-03-06 11:01:41 UTC
> common_description
> Summary

Remove the emoji

> %global godocs          README.md bbscope/README.md bbtargets/README.md\\\
>                         chainredir/README.md checkbypass/README.md\\\
>                         cleanpath/README.md doomxss/README.md eae/README.md\\\
>                         eah/README.md eap/README.md eaparam/README.md\\\
>                         eapath/README.md earh/README.md eefjsf/README.md\\\
>                         genscope/README.md gitdump/README.md\\\
>                         heacoll/README.md knoxssme/README.md\\\
>                         kubemetrics/README.md nrp/README.md rapwp/README.md\\\
>                         removehost/README.md removepro/README.md\\\
>                         robotstxt/README.md rpfu/README.md subtake/README.md\\\
>                         tahm/README.md
> (...)
> %doc README.md bbscope/README.md bbtargets/README.md chainredir/README.md
> %doc checkbypass/README.md cleanpath/README.md doomxss/README.md eae/README.md
> %doc eah/README.md eap/README.md eaparam/README.md eapath/README.md
> %doc earh/README.md eefjsf/README.md genscope/README.md gitdump/README.md
> %doc heacoll/README.md knoxssme/README.md kubemetrics/README.md nrp/README.md
> %doc rapwp/README.md removehost/README.md removepro/README.md
> %doc robotstxt/README.md rpfu/README.md subtake/README.md tahm/README.md

You need to rename the README files during the %prep phase. This is an example in another package:

https://src.fedoraproject.org/rpms/golang-github-jcmturner-gokrb5/blob/rawhide/f/golang-github-jcmturner-gokrb5.spec#_41

> %gopkginstall
> %gopkgfiles

This creates the golang-github-edoardottt-lit-bb-hack-tools-devel header package that I don't think is required by any other package, so it shouldn't be created.

Comment 4 Fedora Review Service 2024-03-06 13:59:23 UTC
Created attachment 2020358 [details]
The .spec file difference from Copr build 7053551 to 7112353

Comment 5 Fedora Review Service 2024-03-06 13:59:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7112353
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265716-golang-github-edoardottt-lit-bb-hack-tools/fedora-rawhide-x86_64/07112353-golang-github-edoardottt-lit-bb-hack-tools/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Mikel Olasagasti Uranga 2024-03-06 20:41:22 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution. Checked with `dnf whatprovides /usr/bin/$cmd`
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 7 Tim Semeijn 2024-03-07 23:32:14 UTC
Thanks for the review Mikel!

Comment 8 Fedora Admin user for bugzilla script actions 2024-03-07 23:33:30 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-edoardottt-lit-bb-hack-tools

Comment 9 Fedora Update System 2024-03-08 00:14:50 UTC
FEDORA-2024-6fb8e0fce6 (golang-github-edoardottt-lit-bb-hack-tools-1.3.5-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6fb8e0fce6

Comment 10 Fedora Update System 2024-03-08 00:17:27 UTC
FEDORA-2024-6fb8e0fce6 (golang-github-edoardottt-lit-bb-hack-tools-1.3.5-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.