Spec URL: https://petersen.fedorapeople.org/reviews/ghc-toml-parser/ghc-toml-parser.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-toml-parser/ghc-toml-parser-1.3.2.0-1.fc41.src.rpm Description: TOML parser using generated lexers and parsers with careful attention to the TOML 1.0.0 semantics for defining tables. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=114080556
Copr build: https://copr.fedorainfracloud.org/coprs/build/7062038 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266093-ghc-toml-parser/fedora-rawhide-x86_64/07062038-ghc-toml-parser/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- package name is OK - license is acceptable for Fedora (ISC) - license is specified correctly - generated with cabal-rpm the standard spec file template is used - builds and installs OK - BR/R/P look OK rpmlint: ghc-toml-parser.x86_64: E: unknown-key 2e51ab58 ghc-toml-parser-devel.x86_64: E: unknown-key 2e51ab58 ghc-toml-parser-doc.noarch: E: unknown-key 2e51ab58 ghc-toml-parser-prof.x86_64: E: unknown-key 2e51ab58 Meh. ghc-toml-parser-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/toml-parser-1.3.2.0/libHStoml-parser-1.3.2.0-K36TYHiztMbDWetW6V7rmZ.a ghc-toml-parser-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.4.5/lib/toml-parser-1.3.2.0/libHStoml-parser-1.3.2.0-K36TYHiztMbDWetW6V7rmZ_p.a Nobody cares about static libraries anyway ;) ghc-toml-parser.x86_64: E: spelling-error ('parsers', '%description -l en_US parsers -> parser, parses, parers') ghc-toml-parser.x86_64: W: no-documentation ghc-toml-parser-prof.x86_64: W: no-documentation All bogus. Package is APPROVED.
Thank you for the review, Zbigniew
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-toml-parser
https://pagure.io/releng/fedora-scm-requests/issue/61061
FEDORA-2024-7d83cbccb6 (ghc-base64-0.4.2.4-28.fc40, ghc-hakyll-4.16.2.0-4.fc40, and 6 more) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d83cbccb6
FEDORA-2024-7d83cbccb6 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7d83cbccb6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7d83cbccb6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b458482d48 (ghc-base64-0.4.2.4-28.fc39, ghc-hakyll-4.16.2.0-4.fc39, and 6 more) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b458482d48
FEDORA-2024-b458482d48 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b458482d48` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b458482d48 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7d83cbccb6 (ghc-base64-0.4.2.4-28.fc40, ghc-hakyll-4.16.2.0-4.fc40, and 6 more) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-b458482d48 (ghc-base64-0.4.2.4-28.fc39, ghc-hakyll-4.16.2.0-4.fc39, and 6 more) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.