Bug 2266307 - Review Request: rust-criterion - Statistics-driven micro-benchmarking library
Summary: Review Request: rust-criterion - Statistics-driven micro-benchmarking library
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/criterion
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-27 14:23 UTC by Daniel Mellado
Modified: 2024-09-12 10:21 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-09-12 10:21:34 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Daniel Mellado 2024-02-27 14:23:55 UTC
Spec URL: https://dmellado.fedorapeople.org/rust-criterion/rust-criterion.spec
SRPM URL: https://dmellado.fedorapeople.org/rust-criterion/rust-criterion-0.5.1-1.fc39.src.rpm

Description:
Statistics-driven micro-benchmarking library.

Fedora Account System Username: dmellado

Comment 1 Daniel Mellado 2024-02-27 14:23:59 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=114132938

Comment 2 Fedora Review Service 2024-02-27 14:32:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7064868
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266307-rust-criterion/fedora-rawhide-x86_64/07064868-rust-criterion/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 blinxen 2024-02-27 15:04:40 UTC
Any special reason you want to package `criterion`?
We usually just patch out benchmark dependencies, since bechmarks are not relevant for Fedora packaging / package maintenance activity.

Comment 4 Fabio Valentini 2024-02-28 21:58:29 UTC
I agree - benchmarks are neither compiled nor run during package builds.
I don't think that packaging a project that will never be used and that only makes build times longer is a good way to spend your time - so please just drop the "criterion" dev-dependency whereever you find it. There are very few legitimate reasons to depend on criterion, but benchmarks are not one of them.

Comment 5 Fabio Valentini 2024-09-12 10:21:34 UTC
I'll go ahead and assume that you're not packaging a benchmarking tool, but submitted this as an (unused during package builds) dependency for something else.


Note You need to log in before you can comment on or make changes to this bug.