Spec URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07064857/crun-vm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07064857/crun-vm-0.1.2-1.src.rpm Description: An OCI Runtime that runs VM images Fedora Account System Username: afaria
Copr build: https://copr.fedorainfracloud.org/coprs/build/7065051 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266310-crun-vm/fedora-rawhide-x86_64/07065051-crun-vm/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/fedora-rawhide-x86_64/07179159-crun-vm/crun-vm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/fedora-rawhide-x86_64/07179159-crun-vm/crun-vm-0.1.3-1.fc41.src.rpm Description: An OCI Runtime that runs VM images Fedora Account System Username: afaria
Spec URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07179185/crun-vm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07179185/crun-vm-0.1.3-1.src.rpm Description: An OCI Runtime that runs VM images Fedora Account System Username: afaria
Copr build: https://copr.fedorainfracloud.org/coprs/build/7179821 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266310-crun-vm/fedora-rawhide-x86_64/07179821-crun-vm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/7179820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266310-crun-vm/fedora-rawhide-x86_64/07179820-crun-vm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Quick comments from a Rust packaging perspective: 1. Please replace "__cargo_is_lib() 0" (which is a private macro and was previously needed as a workaround) with "cargo_install_lib 0" (which is now the official, supported way to override this behaviour as of rust-packaging v26). 2. Bump cargo-rpm-macros dependency to >= 26 (and / or regenerate the spec with rust2rpm v26). 3. Please include the full output of "%cargo_license_summary" from the build.log as a spec comment above the "License" tag. 4. The license tag contains duplicates and can be simplified. > (MIT OR Apache-2.0) AND Unicode-DFS-2016 AND Apache-2.0 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND GPL-2.0-or-later AND MIT AND (MIT OR Apache-2.0) AND MPL-2.0 AND MPL-2.0+ AND (Unlicense OR MIT) Eliminating duplicates and sorting results in: Apache-2.0 AND GPL-2.0-or-later AND MIT AND MPL-2.0 AND MPL.2.0+ AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND (Unlicense OR MIT) Looks good from Rust perspective otherwise.
Thank you Fabio, I addressed your comments. Spec URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07182639/crun-vm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/afaria/crun-vm/srpm-builds/07182639/crun-vm-0.1.3-1.src.rpm Description: An OCI Runtime that runs VM images Fedora Account System Username: afaria
Created attachment 2022548 [details] The .spec file difference from Copr build 7179821 to 7182693
Copr build: https://copr.fedorainfracloud.org/coprs/build/7182693 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266310-crun-vm/fedora-rawhide-x86_64/07182693-crun-vm/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
LGTM given Fabio's comments are addressed and we have a successful copr build.
The Pagure repository was created at https://src.fedoraproject.org/rpms/crun-vm
FEDORA-2024-be71bfe8e2 (crun-vm-0.1.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-be71bfe8e2
FEDORA-2024-be71bfe8e2 (crun-vm-0.1.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.