Bug 2266351 - nibabel man pages are misgenerated
Summary: nibabel man pages are misgenerated
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-nibabel
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sandro
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-02-27 16:55 UTC by Zbigniew Jędrzejewski-Szmek
Modified: 2024-03-23 00:24 UTC (History)
4 users (show)

Fixed In Version: python-nibabel-5.2.0-3.fc41 python-nibabel-5.1.0-7.fc39 python-nibabel-5.1.0-2.fc38 python-nibabel-5.2.0-3.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-02-28 12:32:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Pagure fedora-reproducible-builds/project issue 11 0 None None None 2024-02-28 15:37:55 UTC

Description Zbigniew Jędrzejewski-Szmek 2024-02-27 16:55:59 UTC
Description of problem:

E.g. /usr/share/man/man1/parrec2nii.1.gz:
TRACEBACK(1)                         User Commands                         TRACEBACK(1)
NAME
       Traceback - manual page for Traceback (most recent call last):
DESCRIPTION
   Traceback (most recent call last):
              File "/builddir/build/BUILDROOT/python-niba‐
              bel-5.2.0-2.fc41.x86_64//usr/bin//parrec2nii", line 5, in <module>
              from nibabel.cmdline.parrec2nii import main
       ModuleNotFoundError: No module named 'nibabel'

Comment 1 Sandro 2024-02-28 09:17:30 UTC
Thanks for the report. Since I last touched `nibabel`, I'll take a look.

Comment 2 Ankur Sinha (FranciscoD) 2024-02-28 12:10:01 UTC
I have a fix in place already. A few man pages still include some error strings. Just getting rid of them. Should have a PR open after work once Im home.

Comment 3 Fedora Update System 2024-02-28 12:29:02 UTC
FEDORA-2024-6be364a236 (python-nibabel-5.2.0-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6be364a236

Comment 4 Fedora Update System 2024-02-28 12:32:15 UTC
FEDORA-2024-6be364a236 (python-nibabel-5.2.0-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Fedora Update System 2024-02-28 13:47:45 UTC
FEDORA-2024-a6bbcdaa64 (python-nibabel-5.1.0-2.fc38) has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a6bbcdaa64

Comment 6 Fedora Update System 2024-02-28 13:47:46 UTC
FEDORA-2024-116b098f03 (python-nibabel-5.2.0-3.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-116b098f03

Comment 7 Zbigniew Jędrzejewski-Szmek 2024-02-28 15:37:56 UTC
Thank you for the quick fix.

Actually, I only looked at the man page because I was checking build reproducibility
(https://pagure.io/fedora-reproducible-builds/project/issue/11).
python-nibabel-5.2.0-3.fc41 rebuilds reproducibly, thanks!

Comment 8 Sandro 2024-02-28 16:38:08 UTC
(In reply to Ankur Sinha (FranciscoD) from comment #2)
> I have a fix in place already. A few man pages still include some error
> strings. Just getting rid of them. Should have a PR open after work once Im
> home.

Sorry, I missed your comment. The issue has probably been present for a while. It was the environment not being set up correctly when calling help2man, resulting in Python not finding the modules in BUILDROOT.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> Thank you for the quick fix.
> 
> Actually, I only looked at the man page because I was checking build
> reproducibility
> (https://pagure.io/fedora-reproducible-builds/project/issue/11).
> python-nibabel-5.2.0-3.fc41 rebuilds reproducibly, thanks!

I already thought you stumbled upon the issue for unrelated reasons. But it makes me wonder why the package failed the reproducibility test with the faulty man pages. Looking at the issue link, I see it's a difference between `noarch` and `x86_64`. On the same arch the package should build reproducible even with the faulty man pages, should it not?

Comment 9 Zbigniew Jędrzejewski-Szmek 2024-02-28 16:57:53 UTC
> I see it's a difference between `noarch` and `x86_64`. On the same arch the
> package should build reproducible even with the faulty man pages, should it not?

Yes. Though I'm confused as to why one of the buildroots has "noarch".
I thought that the buildroot always has *some* architecture.

Comment 10 Sandro 2024-02-28 17:18:04 UTC
I'm afraid I don't have an answer to that. I'm as puzzled as you are. My guess would be a difference in build environment / configuration. When I expand `%py3_test_envvars` it uses my machine's arch:

rpm -E '%py3_test_envvars'
\
  CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\
  PATH="/home/sandro/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/bin:$PATH"\
  PYTHONPATH="${PYTHONPATH:-/home/sandro/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/lib64/python3.12/site-packages:/home/sandro/rpmbuild/BUILDROOT/%{NAME}-%{VERSION}-%{RELEASE}.x86_64/usr/lib/python3.12/site-packages}"\
  PYTHONDONTWRITEBYTECODE=1\
  \
  PYTEST_XDIST_AUTO_NUM_WORKERS=8

Maybe some configuration parameter sets it to whatever BuildArch was requested?

Comment 11 Zbigniew Jędrzejewski-Szmek 2024-02-28 20:51:44 UTC
It's probably a difference in how mock is called. In my rebuilder script, I do some some custom things. Koji probably calls mock slightly differently. I don't think this really matters. We don't want the build path to appear in the build output in any way.

Comment 12 Fedora Update System 2024-02-29 01:07:46 UTC
FEDORA-2024-116b098f03 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-116b098f03`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-116b098f03

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-02-29 01:20:17 UTC
FEDORA-2024-3d80324305 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3d80324305`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3d80324305

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2024-02-29 02:01:55 UTC
FEDORA-2024-a6bbcdaa64 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a6bbcdaa64`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a6bbcdaa64

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2024-03-08 01:18:48 UTC
FEDORA-2024-3d80324305 (python-nibabel-5.1.0-7.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2024-03-08 01:54:04 UTC
FEDORA-2024-a6bbcdaa64 (python-nibabel-5.1.0-2.fc38) has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2024-03-23 00:24:03 UTC
FEDORA-2024-116b098f03 (python-nibabel-5.2.0-3.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.