This is a rename of fotoxx: https://bugzilla.redhat.com/show_bug.cgi?id=2266305 Description: Fotocx is a free open source Linux program for editing image files from a digital camera. The goal of fotocx is to meet most image editing needs while remaining easy to use. Summary: Photo editor SRPM: https://fedorapeople.org/~limb/review/fotocx/fotocx-24.11-1.fc41.src.rpm SPEC: https://fedorapeople.org/~limb/review/fotocx/fotocx.spec
Copr build: https://copr.fedorainfracloud.org/coprs/build/7065747 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266382-fotocx/fedora-rawhide-x86_64/07065747-fotocx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file licenses is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 18110 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 17735680 bytes in /usr/share fotocx-24.11-1.fc39.x86_64.rpm:17735680 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: fotocx-24.11-1.fc39.x86_64.rpm fotocx-debuginfo-24.11-1.fc39.x86_64.rpm fotocx-debugsource-24.11-1.fc39.x86_64.rpm fotocx-24.11-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr05hh_e5')] checks: 32, packages: 4 fotocx.x86_64: W: position-independent-executable-suggested /usr/bin/fotocx fotocx.x86_64: W: no-manual-page-for-binary fotocx-snap fotocx.x86_64: W: incoherent-version-in-changelog 24.11 ['24.11-1.fc39', '24.11-1'] fotocx.x86_64: W: files-duplicate /usr/share/fotocx/data/custom_kernel/last-used /usr/share/fotocx/data/custom_kernel/emboss5 fotocx.x86_64: W: files-duplicate /usr/share/pixmaps/fotocx.png /usr/share/fotocx/icons/fotocx.png:/usr/share/fotocx/images/fotocx.png 4 packages and 0 specfiles checked; 0 errors, 5 warnings, 19 filtered, 0 badness; has taken 0.7 s Rpmlint (debuginfo) ------------------- Checking: fotocx-debuginfo-24.11-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0raee930')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "fotocx-debugsource". (none): E: there is no installed rpm "fotocx-debuginfo". (none): E: there is no installed rpm "fotocx". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- http://www.kornelix.net/downloads/downloads/fotocx-24.11-source.tar.gz : CHECKSUM(SHA256) this package : bc3e12a7ae2deb80ff41b14d392f15010eed93eb383dd184d605967c47a78b95 CHECKSUM(SHA256) upstream package : bc3e12a7ae2deb80ff41b14d392f15010eed93eb383dd184d605967c47a78b95 Requires -------- fotocx (rpmlib, GLIBC filtered): binutils dcraw libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libchamplain-0.12.so.0()(64bit) libchamplain-gtk-0.12.so.0()(64bit) libclutter-1.0.so.0()(64bit) libclutter-gtk-1.0.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblcms2.so.2()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libz.so.1()(64bit) openjpeg2-tools perl-Image-ExifTool rtld(GNU_HASH) xdg-utils xmessage fotocx-debuginfo (rpmlib, GLIBC filtered): fotocx-debugsource (rpmlib, GLIBC filtered): Provides -------- fotocx: application() application(fotocx.desktop) fotocx fotocx(x86-64) fotoxx metainfo() metainfo(kornelix.fotocx.metainfo.xml) mimehandler(image/bmp) mimehandler(image/gif) mimehandler(image/jpeg) mimehandler(image/png) mimehandler(image/tiff) fotocx-debuginfo: debuginfo(build-id) fotocx-debuginfo fotocx-debuginfo(x86-64) fotocx-debugsource: fotocx-debugsource fotocx-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name fotocx --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Perl, Java, Ocaml, R, Python, PHP, Haskell, fonts, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH - doc license please add : %license doc/license - changelog please add the release in 24.11 to 24.11-1 - fotocx.x86_64: W: position-independent-executable-suggested /usr/bin/fotocx I don't know if it is possible https://docs.fedoraproject.org/en-US/packaging-guidelines/#_pie
I think instead LDFLAGS="%{optflags}" we should have LDFLAGS="%{build_ldflags}" I forgot to write, I discover this because I was thinking add .packit.xml to this package ...
SRPM: https://fedorapeople.org/~limb/review/fotocx/fotocx-24.11-2.fc41.src.rpm SPEC: https://fedorapeople.org/~limb/review/fotocx/fotocx.spec
Created attachment 2019293 [details] The .spec file difference from Copr build 7065747 to 7068769
Copr build: https://copr.fedorainfracloud.org/coprs/build/7068769 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266382-fotocx/fedora-rawhide-x86_64/07068769-fotocx/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Note: License file copyright is not marked as %license please just add one more file with license %license doc/copyright Package APPROVED
Will do, thank you so much!
The Pagure repository was created at https://src.fedoraproject.org/rpms/fotocx
FEDORA-2024-edf4303145 (fotocx-24.11-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-edf4303145
FEDORA-2024-edf4303145 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-edf4303145 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-edf4303145 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
please add me as co-maintainer . Thank you
FEDORA-2024-edf4303145 (fotocx-24.11-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.