Red Hat Bugzilla – Bug 226648
Merge Review: xorg-x11-xauth
Last modified: 2010-09-03 01:18:31 EDT
Fedora Merge Review: xorg-x11-xauth
Initial Owner: email@example.com
1) I will suggest this pacakge to follow current packaging guidelines and remove
buildroot, %clean section and cleaning of build root in %install
2) See http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F
I think we should remove provides and Obsoletes now. I can't find old packages built on koji.
3) also good to preserve timestamps when using install commands.
4) rpmlint on SRPM and RPM reports
xorg-x11-xauth.src: W: strange-permission mkxauth 0775
xorg-x11-xauth.src:24: W: unversioned-explicit-provides xauth
xorg-x11-xauth.src:25: W: unversioned-explicit-provides mkxauth
xorg-x11-xauth.src:27: W: unversioned-explicit-obsoletes XFree86-xauth
xorg-x11-xauth.src:27: W: unversioned-explicit-obsoletes mkxauth
xorg-x11-xauth.i686: W: obsolete-not-provided XFree86-xauth
xorg-x11-xauth.i686: W: obsolete-not-provided XFree86
xorg-x11-xauth.i686: W: self-obsoletion mkxauth obsoletes mkxauth
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/AUTHORS
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/README
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/NEWS
Created attachment 432892 [details]
I have tried to cleanup spec and here is patch which will fix above issues. Just need to add Changelog entry. and Fix permission for file mkxauth
Looks koji build is successful with new changes.
After repetitive pings on bz and IRC to sandmann and ajax, looking into discussion happened in yesterday's FESCo meeting where X/Desktop team members almost shown un-willingness to fix this review, I am pushing back this to NEW queue.
Mostly addressed in F15. The explicit provides are not removed though, all the X collection packages provide their binaries explicitly so people don't need to rely on a particular package providing them.
Looks no one yet officially reviewed this package. Not sure if recent approvals from FESCo allows to close the reviews without any reviewer reviewing changes.
So, I am re-opening this.
I think generally maintainer should provide koji build link for final review.
Thanks Ajax for the updated build. This package is reviewed now as requested changes are partially committed.
I see that rpmlint still showing
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/AUTHORS
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/README
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/NEWS
but zero-length files are harmless.
Closing this now.