Bug 226648 – Merge Review: xorg-x11-xauth

Bugzilla will be upgraded to version 5.0 on a still to be determined date in the near future. The original upgrade date has been delayed.

Bug 226648 - Merge Review: xorg-x11-xauth

Summary:	Merge Review: xorg-x11-xauth

Status:	CLOSED NEXTRELEASE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	Package Review (Show other bugs)
Sub Component:
Version:	rawhide
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Parag AN(पराग)
QA Contact:	Fedora Package Reviews List
Docs Contact:

URL:
Whiteboard:
Keywords:	Reopened

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-31 16:33 EST by Nobody's working on this, feel free to take it
Modified:	2010-09-03 01:18 EDT (History)
CC List:	4 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2010-09-03 01:18:31 EDT
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Flags:	panemade: fedora‑review+

Attachments	(Terms of Use)
xorg-x11-xauth-spec-cleanup.patch (1.89 KB, text/plain) 2010-07-19 09:49 EDT, Parag AN(पराग)	no flags	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Nobody's working on this, feel free to take it 2007-01-31 16:33:59 EST

Fedora Merge Review: xorg-x11-xauth

http://cvs.fedora.redhat.com/viewcvs/devel/xorg-x11-xauth/
Initial Owner: sandmann@redhat.com

Comment 1 Parag AN(पराग) 2010-07-19 09:41:42 EDT

1) I will suggest this pacakge to follow current packaging guidelines and remove 
buildroot, %clean section and cleaning of build root in %install

2) See http://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages#Do_I_need_to_Provide_my_old_package_names.3F

I think we should remove provides and Obsoletes now. I can't find old packages built on koji.

3) also good to preserve timestamps when using install commands.

4) rpmlint on SRPM and RPM reports
xorg-x11-xauth.src: W: strange-permission mkxauth 0775
xorg-x11-xauth.src:24: W: unversioned-explicit-provides xauth
xorg-x11-xauth.src:25: W: unversioned-explicit-provides mkxauth
xorg-x11-xauth.src:27: W: unversioned-explicit-obsoletes XFree86-xauth
xorg-x11-xauth.src:27: W: unversioned-explicit-obsoletes mkxauth
xorg-x11-xauth.i686: W: obsolete-not-provided XFree86-xauth
xorg-x11-xauth.i686: W: obsolete-not-provided XFree86
xorg-x11-xauth.i686: W: self-obsoletion mkxauth obsoletes mkxauth
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/AUTHORS
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/README
xorg-x11-xauth.i686: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/NEWS

Comment 2 Parag AN(पराग) 2010-07-19 09:49:42 EDT

Created attachment 432892 [details]
xorg-x11-xauth-spec-cleanup.patch

I have tried to cleanup spec and here is patch which will fix above issues. Just need to add Changelog entry. and Fix permission for file mkxauth

Comment 3 Parag AN(पराग) 2010-07-19 09:50:16 EDT

Looks koji build is successful with new changes.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2328928

Comment 4 Parag AN(पराग) 2010-08-02 11:06:34 EDT

sandmann ping

Comment 5 Parag AN(पराग) 2010-08-09 00:53:17 EDT

sandmann ping    
ajax ping

Comment 6 Parag AN(पराग) 2010-08-11 00:20:34 EDT

After repetitive pings on bz and IRC to sandmann and ajax, looking into discussion happened in yesterday's FESCo meeting where X/Desktop team members almost shown un-willingness to fix this review, I am pushing back this to NEW queue.

Comment 7 Adam Jackson 2010-08-30 16:11:57 EDT

Mostly addressed in F15.  The explicit provides are not removed though, all the X collection packages provide their binaries explicitly so people don't need to rely on a particular package providing them.

Comment 8 Parag AN(पराग) 2010-08-30 21:36:44 EDT

Looks no one yet officially reviewed this package. Not sure if recent approvals from FESCo allows to close the reviews without any reviewer reviewing changes.

So, I am re-opening this.

Comment 9 Parag AN(पराग) 2010-09-01 06:49:43 EDT

I think generally maintainer should provide koji build link for final review.

Comment 10 Parag AN(पराग) 2010-09-03 01:18:31 EDT

Thanks Ajax for the updated build. This package is reviewed now as requested changes are partially committed.

I see that rpmlint still showing
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/AUTHORS
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/README
xorg-x11-xauth.x86_64: E: zero-length /usr/share/doc/xorg-x11-xauth-1.0.2/NEWS

but zero-length files are harmless.

Closing this now.

Note You need to log in before you can comment on or make changes to this bug.