Bug 226649 - Merge Review: xorg-x11-xbitmaps
Merge Review: xorg-x11-xbitmaps
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-31 16:34 EST by Nobody's working on this, feel free to take it
Modified: 2012-06-15 12:33 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-10-28 01:41:51 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+


Attachments (Terms of Use)

  None (edit)
Description Nobody's working on this, feel free to take it 2007-01-31 16:34:11 EST
Fedora Merge Review: xorg-x11-xbitmaps

http://cvs.fedora.redhat.com/viewcvs/devel/xorg-x11-xbitmaps/
Initial Owner: sandmann@redhat.com
Comment 1 Thomas Spura 2009-12-19 16:52:56 EST
$ rpmlint xorg-x11-xbitmaps.spec xorg-x11-xbitmaps-1.1.0-1.fc13.src.rpm noarch/xorg-x11-xbitmaps-1.1.0-1.fc13.noarch.rpm 
xorg-x11-xbitmaps.spec:17: W: unversioned-explicit-provides xbitmaps
xorg-x11-xbitmaps.spec:18: W: unversioned-explicit-provides xbitmaps-devel
xorg-x11-xbitmaps.src:17: W: unversioned-explicit-provides xbitmaps
xorg-x11-xbitmaps.src:18: W: unversioned-explicit-provides xbitmaps-devel
xorg-x11-xbitmaps.noarch: W: no-documentation
xorg-x11-xbitmaps.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/xbitmaps.pc
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

- There is ChangeLog and COPYING for %doc.

- Isn't %configure and --libdir a bit hacky?
  You assume, that the latest used --libdir is used in the configure. Don't know
  if that's always the case. Hope so ;)

- Could the provides xbitmaps deleted, if bitmaps requires xorg-x11-xbitmaps and not xbitmaps anymore?
  AFAIK this is the only programm which uses 'xbitmaps'

  $ repoquery --whatrequires xbitmaps
    bitmap-0:1.0.3-6.fc12.x86_64

- parallel make is not really needed, because nothing is build in make, but could you use 'make %{?_smp_mflags}' anyway?

- from https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files
  requires: pkgconfig is missing


Rest looks ok.
Comment 2 Thomas Spura 2009-12-19 16:56:07 EST
Hmm, just wondering, which package owns /usr/include/X11

$ yum provides /usr/include/X11 says:
xorg-x11-proto-devel and xorg-x11-xtrans-devel

But this package should require a programm, for owning /usr/include/X11, but those two don't make sense...
Comment 3 Thomas Spura 2010-01-26 18:37:45 EST
CC'ing Adam Jackson
Comment 4 Adam Jackson 2010-08-30 16:15:56 EDT
(In reply to comment #1)

> - Isn't %configure and --libdir a bit hacky?
>   You assume, that the latest used --libdir is used in the configure. Don't
> know
>   if that's always the case. Hope so ;)

It is.

Fixed the doc stuff and smp_mflags in F15.  The rest is minor enough to not need fixing; if a provenpackager wants to clean that up, feel free.
Comment 5 Parag AN(पराग) 2010-08-30 21:38:58 EDT
where is the official review?
Comment 6 Parag AN(पराग) 2010-09-01 09:35:57 EDT
I will leave this package to be reviewed by Thomas Spura as he has done some initial review.
Comment 7 Parag AN(पराग) 2010-10-28 01:41:51 EDT
Now all the 3 packages(xorg-x11-xbitmaps, xorg-x11-proto-devel and xorg-x11-xtrans-devel) own /usr/include/X11

Done some cleanup commits already.

APPROVED.
Comment 8 Parag AN(पराग) 2012-06-15 12:33:28 EDT
hah! howcome i missed this package to set the flag fedora-review+ ?

Note You need to log in before you can comment on or make changes to this bug.