Fedora Merge Review: xsri
Initial Owner: email@example.com
Here is the long awaited review for this package:
* Description: The description is insufficient. The term "root window" does not mean much to most people. What does "displays images on the root window" mean? I think it should be replaced by modern day terms such as "sets the wallpaper".
* rpmlint says:
xsri.spec:20: W: setup-not-quiet
Use a -q flag on %setup macro
xsri.spec: E: no-cleaning-of-buildroot %install
buildroot must be cleaned at the beginning of %install
xsri.src: W: no-url-tag
I guess this package does not have an URL at all, so this is fine.
xsri.x86_64: E: zero-length /usr/share/doc/xsri-2.1.0/NEWS
The file NEWS is empty, doesn't need to be packaged.
xsri.x86_64: W: incoherent-version-in-changelog 2.1.0-15 ['1:2.1.0-15.fc10', '1:2.1.0-15']
Typo? Can be fixed easily.
* Group: System Environment/Base
Is this the best one to pick?
* We prefer %defattr(-,root,root,-)
* BuildRequires: gtk2-devel >= 1.3.13
From the guidelines: "if the lowest possible requirement is so old that nobody has a version older than that installed on any target distribution release, there's no need to include the version in the dependency at all."
gtk2-1.3 is ancient, so no need to use the specific version here.
* Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment.
I added Jason Tibbitts to the CC since he's the last known maintainer.
re-ping? shall I add someone else to CC?
re-re-ping? I added two other previous maintainers to CC. Please do not ignore!
Any particular reason why this merge review is being ignored?
Just looking back at comment #1, I have no idea at all why you would think I am the last known maintainer. I've never had anything to do with the maintenance of this package. I fixed the license tag ages ago, but I fixed the license tags of many packages.
and how would I know that you fixed license tag of many packages? :)
I just saw your name in the changelog as the last human who edited the package. I am sorry, my bad.
Almost 2 years since the review and still no progress. Why?
The bottom line is that merge reviews aren't a priority for some folks, especially for packages like this one.
If you have a proposed patch for this or any other merge review for rarely used leaf package, ping me and I will apply it.
~/fedora/xsri% cat dead.package
This package was retired on 2011-07-25 due to it being unable to build this package for multiple releases (FTBFS).
This bug just popped out when I searched for packages under review but looks like this package was retired already.
Dropping the flag fedora-review?